-
Notifications
You must be signed in to change notification settings - Fork 473
Update bindings to SDL 2.0.20 #1213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
89af657
to
9d26e50
Compare
it's fine to refactor, but please keep the old type and mark it a "deprecated", and use a new type for a few versions. We don't want to break everything in one update.
I'm extremely familiar with NV, so we will have to find people to test it for us. If we can't, label this part of the docs with UNTESTED UNSTABLE so that people that know what they are doing can guide us on the best way to implement this part. There is a lot of code to cover here, so it might take some time to review everything. |
b8c2f11
to
1e53495
Compare
Ack. Now I thnk about it, the wrapper for SDL_RenderGeometryRaw isn't going to work. The C version does everything with pointers and strides, so it supports the pattern of having one array per data type, and the pattern of having one array with different data types interleaved. My wrapper goes for option 1, but loads of things go for option 2. Maybe the solution is to make a second wrapper, which takes |
Would you mind splitting this into 2 different pull requests? One for simply updating to 2.0.20 with the very simple new calls added (rumble, audio, joystick, window, etc); and then another entirely different PR for the video and renderer-related stuff (with Color as well)? This PR is very large, I'm thankful for all the work but it's really hard to follow what is intereconnected to each other and what is not here. |
This is great @moralrecordings! I am using your branch locally with SDL 2.0.20 and the geometry-function ( EDIT: |
Ack sorry, got distracted by other things! That sounds reasonable, I'll pare this back to just the basics and split the new geometry/render/colour features into a new PR. |
1e53495
to
12587f1
Compare
12587f1
to
fffd2b4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very minor changes requested, otherwise very nice work!
@moralrecordings please cargo fmt, push and then once the CI checks there are no regressions we should be good to go. |
8892974
to
39b05d5
Compare
Thanks! |
Notes:
SDL2_INCLUDE_PATH=path/to/SDL-2.0.20/include cargo build --features use-bindgen