Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(preview middleware): remove hard coded webapp path #2857

Merged
merged 7 commits into from
Feb 6, 2025
Merged

fix(preview middleware): remove hard coded webapp path #2857

merged 7 commits into from
Feb 6, 2025

Conversation

heimwege
Copy link
Contributor

@heimwege heimwege commented Feb 3, 2025 •
edited
Loading

see #2589

and refactoring:

  • create own functions for anonymous express handlers to reduce cognitive complexity

@heimwege heimwege added the preview-middleware @sap-ux/preview-middleware label Feb 3, 2025
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Feb 3, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: f10bf00

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@sap-ux/preview-middleware Patch
@sap-ux/create Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@heimwege heimwege marked this pull request as ready for review February 4, 2025 22:19
@heimwege heimwege requested a review from a team as a code owner February 4, 2025 22:19
@heimwege heimwege marked this pull request as draft February 4, 2025 22:54
heimwege and others added 2 commits February 5, 2025 10:13
@heimwege
Merge branch 'main' of github.com:SAP/open-ux-tools into fix/preview-…
6a326b9 
…middleware/remove-hard-coded-webapp-path

# Conflicts:
#	packages/preview-middleware/src/base/flp.ts
@heimwege
Merge branch 'main' into fix/preview-middleware/remove-hard-coded-web…
b6b396c 
…app-path
@heimwege heimwege mentioned this pull request Feb 3, 2025
Closed
1 task
@heimwege heimwege marked this pull request as ready for review February 5, 2025 15:19
johannes-kolbe
johannes-kolbe approved these changes Feb 5, 2025
View reviewed changes
Copy link
Contributor

@johannes-kolbe johannes-kolbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Refactoring looks good
  • Replacement of webapp path lg
  • changeset provided
  • Did not test manually

Thanks @heimwege

@nikmace nikmace self-requested a review February 6, 2025 07:18
nikmace
nikmace approved these changes Feb 6, 2025
View reviewed changes
Copy link
Contributor

@nikmace nikmace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good
Previewed locally
Coverage is good

One thing, could you please update the PR title to be:
fix(preview middleware): remove hard coded webapp path

@heimwege heimwege changed the title Fix/preview middleware/remove hard coded webapp path fix(preview middleware): remove hard coded webapp path Feb 6, 2025
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Feb 6, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
88.2% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@heimwege heimwege merged commit b214776 into main Feb 6, 2025
16 checks passed
@heimwege heimwege deleted the fix/preview-middleware/remove-hard-coded-webapp-path branch February 6, 2025 08:38
devinea added a commit that referenced this pull request Feb 6, 2025
@devinea
Merge remote-tracking branch 'origin/fix_cap_ws_enable' into fix_cap_…
242b53a 
…ws_enable

* origin/fix_cap_ws_enable:
  Create selfish-lobsters-yawn.md
  fix(deps): update dependency axios to v1.7.9 (#2868)
  chore: apply latest changesets
  fix(preview middleware): remove hard coded webapp path (#2857)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikmace nikmace nikmace approved these changes

@johannes-kolbe johannes-kolbe johannes-kolbe approved these changes

Assignees
No one assigned
Labels
preview-middleware @sap-ux/preview-middleware
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@heimwege @nikmace @johannes-kolbe