Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(preview middleware): remove hard coded webapp path #2857

Merged
merged 7 commits into from
Feb 6, 2025
Merged

fix(preview middleware): remove hard coded webapp path #2857

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
bf7759d
refactoring
heimwege Feb 3, 2025
fe1c68b
add changeset
heimwege Feb 3, 2025
6a326b9
Merge branch 'main' of github.com:SAP/open-ux-tools into fix/preview-…
heimwege Feb 5, 2025
b6b396c
Merge branch 'main' into fix/preview-middleware/remove-hard-coded-web…
heimwege Feb 5, 2025
c3d7276
fix sonar issue
heimwege Feb 5, 2025
23fe91f
Merge branch 'main' into fix/preview-middleware/remove-hard-coded-web…
johannes-kolbe Feb 5, 2025
f10bf00
Merge branch 'main' into fix/preview-middleware/remove-hard-coded-web…
johannes-kolbe Feb 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/silver-jobs-peel.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@sap-ux/preview-middleware': patch
---

fix: remove hard coded usage of webapp folder
2 changes: 1 addition & 1 deletion packages/preview-middleware/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,7 +188,7 @@ return flp.router


## [Migration](#migration)
If you have no custom modifications in the local Fiori Launchpad sandbox files (`webapp/test/flpSandbox.html` or `webapp/test/flpSandboxMockserver.html`), the conversion is finished.
If you have no custom modifications in the local Fiori Launchpad sandbox files (`<webapp>/test/flpSandbox.html` or `<webapp>/test/flpSandboxMockserver.html`), the conversion is finished.

If you have custom modifications in the local Fiori Launchpad sandbox files, you need to migrate them into a custom .js or .ts file (depending on your setup) and integrate this file as a custom `init` script into the configuration options of the middleware.

Expand Down
Loading
Loading