-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FN fix #144
FN fix #144
Conversation
babenek
commented
Jun 5, 2024
•
edited
Loading
edited
- analyze value before obfuscation to keep the same char set
- corrections for https://github.com/Samsung/CredSweeper/pull/563/files
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please, add values endings
meta/34cb4bc8.csv
Outdated
@@ -25,7 +25,7 @@ Id,FileID,Domain,RepoName,FilePath,LineStart,LineEnd,GroundTruth,WithWords,Value | |||
13631,4c636203,GitHub,34cb4bc8,data/34cb4bc8/src/4c636203.cs,38,38,F,F,,,F,F,,,,,0,0,F,F,F,Secret | |||
13632,4c636203,GitHub,34cb4bc8,data/34cb4bc8/src/4c636203.cs,25,25,F,F,,,F,F,,,,,0,0,F,F,F,Secret | |||
13696,58950d10,GitHub,34cb4bc8,data/34cb4bc8/src/58950d10.cs,29,29,F,F,,,F,F,,,,,0,0,F,F,F,Token | |||
17253,bdac7f67,GitHub,34cb4bc8,data/34cb4bc8/test/bdac7f67.cs,347,347,F,F,,,F,F,,,,,0,0,F,F,F,Token | |||
17253,bdac7f67,GitHub,34cb4bc8,data/34cb4bc8/test/bdac7f67.cs,347,347,T,F,105,,F,F,,,,,0,0,F,F,F,Token |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing end of value
@@ -9128,7 +9128,7 @@ Id,FileID,Domain,RepoName,FilePath,LineStart,LineEnd,GroundTruth,WithWords,Value | |||
112476,07d8fbd6,GitHub,2ba83c6a,data/2ba83c6a/test/07d8fbd6.t,37,37,F,F,,,F,F,,,,,0.00,,F,F,F,Secret:Key | |||
112477,07d8fbd6,GitHub,2ba83c6a,data/2ba83c6a/test/07d8fbd6.t,40,40,F,F,,,F,F,,,,,0.00,,F,F,F,Secret:Key | |||
112478,07d8fbd6,GitHub,2ba83c6a,data/2ba83c6a/test/07d8fbd6.t,54,54,F,F,,,F,F,,,,,0.00,,F,F,F,Password:Key:Salt | |||
112479,07d8fbd6,GitHub,2ba83c6a,data/2ba83c6a/test/07d8fbd6.t,63,63,F,F,,,F,F,,,,,0.00,,F,F,F,Secret:Key | |||
112479,07d8fbd6,GitHub,2ba83c6a,data/2ba83c6a/test/07d8fbd6.t,63,63,T,F,73,,F,F,,,,,0.00,,F,F,F,Secret:Key |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing end of value
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
various length may be for different rules ;)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
upd
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved