Basic node import #19
Conversation
|
The bug in reclaimer should be fixed once the pull request is accepted. I consider this pull request final now. |
|
That is, final if the conversion function isn't suddenly moved before we've handled this. |
|
This should be ready for re-review now. |
|
Supports setting scaling, sizes for nodes. By default imports at Blender's metric (meters) size. Supports .gbxmodel, .model, .jms files. |
|
I know we don't have Blender mocks yet, but if we did, what automated tests would you write? Let's get that stuff written down somewhere (preferably an issue) so we don't forget to add test coverage for this stuff later. |
Indirectly fix a module being registered instead of unregistered.
|
Addressed review comments |
|
|
||
| return sphere | ||
|
|
||
| def create_cone(name="new_cone", base_size=1.0, height=3.0): |
There was a problem hiding this comment.
The only difference between create_sphere and create_cone is the calls bmesh.ops.create_uvsphere and bmesh.ops.create_cone. Can we do something to reduce the boilerplate required for any new shape?
There was a problem hiding this comment.
Yeah, but I'd like to get the importing done at a basic level before I go in and do good stuff for shapes. I want to get models in before I worry about those details.
There was a problem hiding this comment.
I want to move onto markers, and then geometry before I worry too much about the shapes of the nodes and markers
Doesn't support different shapes right now.
This should be all the basic functionality we need, but right now we're running issues with some bugs in the reclaimer library. I'd like to fix those and then test this all again.Once we can fix the bugs in those libraries we might as well move the mode to mod2 conversion function into reclaimer instead of mozzarilla too, so we don't need to include it in our code.
If you try this, and you see the nodes all jumbled up in a little mess, that's the bug in reclaimer's doing. I'll update this pull request once we've made progress on that.