Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Basic node import #19
Basic node import #19
Changes from 34 commits
897410e
df17d72
0b8ee7d
528e555
6bc3358
90d210e
c95d858
6deb743
e2502f6
fee15c5
3e0d121
657cf2b
33fdd1d
7c21668
2d362cc
c1dde58
6206d7c
c34daff
c50ecf1
feeb792
9c0c30c
8fff147
03a6129
6e108b1
fed75d2
9011895
e40ac5b
b66d331
194361b
46d61b9
80292de
b57eebd
45f0c4b
144bf20
2c9bfcf
40c2d12
506b4b0
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The only difference between
create_sphere
andcreate_cone
is the callsbmesh.ops.create_uvsphere
andbmesh.ops.create_cone
. Can we do something to reduce the boilerplate required for any new shape?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, but I'd like to get the importing done at a basic level before I go in and do good stuff for shapes. I want to get models in before I worry about those details.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I want to move onto markers, and then geometry before I worry too much about the shapes of the nodes and markers