Skip to content

Automatic Keyword Generation #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Feb 27, 2020
Merged

Automatic Keyword Generation #29

merged 8 commits into from
Feb 27, 2020

Conversation

noahzemlin
Copy link
Member

This PR adds the automatic generation of keywords.txt when build.sh is run. Additionally, the CI will check if the keywords.txt was updated and will fail otherwise.

Closes #9

@noahzemlin noahzemlin requested a review from jkleiber February 27, 2020 17:43
@noahzemlin
Copy link
Member Author

I'll squash when merging due to the large number of commits to debug the CI lol

@codecov
Copy link

codecov bot commented Feb 27, 2020

Codecov Report

Merging #29 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #29   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            9         9           
  Lines          457       457           
=========================================
  Hits           457       457           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 416ca46...fbf7e21. Read the comment docs.

Copy link
Contributor

@jkleiber jkleiber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@noahzemlin noahzemlin merged commit 98b9915 into master Feb 27, 2020
@noahzemlin noahzemlin deleted the feat/automatic-keywords branch February 27, 2020 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Automatically extract keywords
2 participants