Fix for building standalone jar with included libs and fix for run-mapper.sh #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
builds a jar with all the dependent libraries included for easier depployment
If -jar argument is given classpath given by -cp is ignored, this is a fix for this issue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fix for
run-mapper.shskips the use of the -jar argument and gives the main class as an argument instead. When -jar is used -cp is ignored:http://docs.oracle.com/javase/7/docs/technotes/tools/solaris/java.html#jar
When you use this option, the JAR file is the source of all user classes, and other user class path settings are ignored.The change in
pom.xmladds a second jar file for the target where all the libraries are included.This makes the application easier to run without the need of
run-mapper.sh