Use *_dump_str instead of deleted *_dump
#378
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kounelisagis
force-pushed
the
agis/use_dump_str
branch
from
39b1366 to
ac48cbf
Compare
Member
teo-tsirpanis
left a comment
teo-tsirpanis
left a comment
There was a problem hiding this comment.
We should add new DumpToString() functions that return a string (example), and implement the existing dump functions in terms of these.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In TileDB-Inc/TileDB#5585 the following dump C APIs will be removed:
tiledb_array_schema_dumptiledb_enumeration_dumptiledb_attribute_dumptiledb_dimension_dumptiledb_domain_dumpThis PR transitions to the corresponding
*_dump_strC APIs.