-
Notifications
You must be signed in to change notification settings - Fork 200
Remove deprecated dump APIs
#5585
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
REST-CI fails because TileDB-Go references the now-deleted |
teo-tsirpanis
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reverting approval until we migrate TileDB-Go.
|
TileDB-Go PR: TileDB-Inc/TileDB-Go#378 |
bekadavis9
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for getting this done so quickly!
|
@teo-tsirpanis, you are blocking merging because you had requested for changes. |
Following #5026 and #5179, and in accordance with our deprecation cycle, several dump C APIs and their corresponding CPP APIs have been deprecated for three releases - since version 2.26 - and should be removed with the release 2.29. This PR removes them. The C APIs removed are:
tiledb_array_schema_dumptiledb_enumeration_dumptiledb_attribute_dumptiledb_dimension_dumptiledb_domain_dumptiledb_group_dump_strGoing forward, the corresponding
*_dump_strC APIs and the C++operator<<overload should be used instead. For the removedtiledb_group_dump_str, thetiledb_group_dump_str_v2C API should be used as a replacement.Closes CORE-302
TYPE: DEPRECATION
DESC: Remove deprecated dump APIs