Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Coral intake + algae pivot #27

Merged
merged 14 commits into from
Feb 5, 2025
Merged

Coral intake + algae pivot #27

merged 14 commits into from
Feb 5, 2025

Conversation

junocapra
Copy link
Contributor

No description provided.

@junocapra junocapra linked an issue Jan 15, 2025 that may be closed by this pull request
Write Intake code #15
Closed
JacksonElia
JacksonElia approved these changes Jan 15, 2025
View reviewed changes
Copy link
Member

@JacksonElia JacksonElia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good! Great job! I just had a few formatting things, and we need to make sure to revert the x swerve code and pull from main.

src/main/java/frc/robot/commands/drive/Eject.java Outdated
@@ -0,0 +1,27 @@
package frc.robot.commands.drive;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Eject and Intake shouldn't be in the drive folder. Put them in the intake folder

src/main/java/frc/robot/commands/drive/Eject.java Outdated
this.intakeSubsystem = intakeSubsystem;
addRequirements(this.intakeSubsystem);
}

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make sure to put the @OverRide tag above the methods inherited from Command.

src/main/java/frc/robot/subsystems/intake/PhysicalIntake.java Outdated
intakeConfig.MotorOutput.NeutralMode = NeutralModeValue.Brake;
intakeConfig.MotorOutput.DutyCycleNeutralDeadband = HardwareConstants.MIN_FALCON_DEADBAND;

intakeConfig.CurrentLimits.StatorCurrentLimit = 0.0;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would make these current limits constants. We should try our best to avoid magic numbers

@junocapra
Copy link
Contributor Author

@JacksonElia ready for review

@Ishan1522
Copy link
Member

/format

@Ishan1522
Copy link
Member

Ishan1522 commented Jan 19, 2025 •
edited
Loading

All ya gotta do here is pull from main and rename motor to intakeMotor @junocapra

@Ishan1522
Copy link
Member

@junocapra the coral pivot is now the algae pivot, sorry!

@Ishan1522
Copy link
Member

good job juno! this will be ready to merge after you finish up simulation, clean up and format the code, and add docstrings to the methods in the interface and the subsystem. Thanks :)

I can help with these things if you need it.

@Ishan1522 Ishan1522 linked an issue Feb 4, 2025 that may be closed by this pull request
Write code for the de-algefier (how to spell??) #33
Closed
@Ishan1522 Ishan1522 changed the title Juno: Finished Advantagekit Intake Coral intake + algae pivot Feb 4, 2025
@junocapra
Copy link
Contributor Author

Finished algae pivot

@Ishan1522 Ishan1522 merged commit d66622d into main Feb 5, 2025
4 checks passed
@Ishan1522 Ishan1522 deleted the juno/intake branch February 5, 2025 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JacksonElia JacksonElia JacksonElia approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Reefscape project
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Write code for the de-algefier (how to spell??) Write Intake code
3 participants
@junocapra @Ishan1522 @JacksonElia