Skip to content

fix(deps): update dependency express to v5 #1586

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Apr 1, 2025

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
express (source) 4.21.2 -> 5.1.0 age adoption passing confidence

Release Notes

expressjs/express (express)

v5.1.0

Compare Source

========================

  • Add support for Uint8Array in res.send()
  • Add support for ETag option in res.sendFile()
  • Add support for multiple links with the same rel in res.links()
  • Add funding field to package.json
  • perf: use loop for acceptParams
  • refactor: prefix built-in node module imports
  • deps: remove setprototypeof
  • deps: remove safe-buffer
  • deps: remove utils-merge
  • deps: remove methods
  • deps: remove depd
  • deps: debug@^4.4.0
  • deps: body-parser@^2.2.0
  • deps: router@^2.2.0
  • deps: content-type@^1.0.5
  • deps: finalhandler@^2.1.0
  • deps: qs@^6.14.0
  • deps: [email protected]
  • deps: [email protected]

v5.0.1

Compare Source

==========

v5.0.0

Compare Source

=========================

  • remove:
    • path-is-absolute dependency - use path.isAbsolute instead
  • breaking:
    • res.status() accepts only integers, and input must be greater than 99 and less than 1000
      • will throw a RangeError: Invalid status code: ${code}. Status code must be greater than 99 and less than 1000. for inputs outside this range
      • will throw a TypeError: Invalid status code: ${code}. Status code must be an integer. for non integer inputs
    • deps: [email protected]
    • res.redirect('back') and res.location('back') is no longer a supported magic string, explicitly use req.get('Referrer') || '/'.
  • change:
    • res.clearCookie will ignore user provided maxAge and expires options
  • deps: cookie-signature@^1.2.1
  • deps: [email protected]
  • deps: merge-descriptors@^2.0.0
  • deps: serve-static@^2.1.0
  • deps: [email protected]
  • deps: accepts@^2.0.0
  • deps: mime-types@^3.0.0
    • application/javascript => text/javascript
  • deps: type-is@^2.0.0
  • deps: content-disposition@^1.0.0
  • deps: finalhandler@^2.0.0
  • deps: fresh@^2.0.0
  • deps: body-parser@^2.0.1
  • deps: send@^1.1.0

Configuration

📅 Schedule: Branch creation - "before 3am" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@renovate renovate bot added dependencies PRs or issues relating to dependencies renovate labels Apr 1, 2025
Copy link
Contributor Author

renovate bot commented Apr 1, 2025

⚠️ Artifact update problem

Renovate failed to update an artifact related to this branch. You probably do not want to merge this PR as-is.

♻ Renovate will retry this branch, including artifacts, only when one of the following happens:

  • any of the package files in this branch needs updating, or
  • the branch becomes conflicted, or
  • you click the rebase/retry checkbox if found above, or
  • you rename this PR's title to start with "rebase!" to trigger it manually

The artifact failure details are included below:

File name: package-lock.json
npm warn Unknown env config "store". This will stop working in the next major version of npm.
npm error code ERESOLVE
npm error ERESOLVE could not resolve
npm error
npm error While resolving: @triliumnext/[email protected]
npm error Found: [email protected]
npm error node_modules/express
npm error   express@"5.1.0" from the root project
npm error   peer express@">= 4.17.0" from [email protected]
npm error   node_modules/express-openid-connect
npm error     express-openid-connect@"^2.17.1" from the root project
npm error   2 more (express-rate-limit, swagger-ui-express)
npm error
npm error Could not resolve dependency:
npm error peer express@"^4.16.4" from @triliumnext/[email protected]
npm error node_modules/@triliumnext/express-partial-content
npm error   @triliumnext/express-partial-content@"1.0.1" from the root project
npm error
npm error Conflicting peer dependency: [email protected]
npm error node_modules/express
npm error   peer express@"^4.16.4" from @triliumnext/[email protected]
npm error   node_modules/@triliumnext/express-partial-content
npm error     @triliumnext/express-partial-content@"1.0.1" from the root project
npm error
npm error Fix the upstream dependency conflict, or retry
npm error this command with --force or --legacy-peer-deps
npm error to accept an incorrect (and potentially broken) dependency resolution.
npm error
npm error
npm error For a full report see:
npm error /runner/cache/others/npm/_logs/2025-04-01T01_38_41_542Z-eresolve-report.txt
npm error A complete log of this run can be found in: /runner/cache/others/npm/_logs/2025-04-01T01_38_41_542Z-debug-0.log

@pano9000
Copy link
Member

pano9000 commented Apr 1, 2025

this will need some attention, as there were some breaking changes:
https://expressjs.com/en/guide/migrating-5.html

not sure if we are affected or not – but before merging, we should check

@pano9000
Copy link
Member

pano9000 commented Apr 2, 2025

if no one objects, I'll take a stab at updating to Express v5 tomorrow evening ­

@eliandoran
Copy link
Contributor

eliandoran commented Apr 3, 2025

if no one objects, I'll take a stab at updating to Express v5 tomorrow evening ­

Feel free. We'll merge it after the stable.

You'd most likely need to update the dependencies in https://github.com/TriliumNext/express-partial-content (and fix any potential build errors).

@eliandoran eliandoran marked this pull request as draft April 3, 2025 15:42
@eliandoran eliandoran added this to the v0.93.0 milestone Apr 3, 2025
@pano9000
Copy link
Member

pano9000 commented Apr 3, 2025

PR for our express-partial-content fork is here: TriliumNext/express-partial-content#1

we would then need a new release for it as well then

@pano9000
Copy link
Member

pano9000 commented Apr 4, 2025

closing this one in favor of #1626

@pano9000 pano9000 closed this Apr 4, 2025
Copy link
Contributor Author

renovate bot commented Apr 4, 2025

Renovate Ignore Notification

Because you closed this PR without merging, Renovate will ignore this update. You will not get PRs for any future 5.x releases. But if you manually upgrade to 5.x then Renovate will re-enable minor and patch updates automatically.

If you accidentally closed this PR, or if you changed your mind: rename this PR to get a fresh replacement PR.

@renovate renovate bot deleted the renovate/express-5.x branch April 4, 2025 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies PRs or issues relating to dependencies renovate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants