deps: manual upgrade to express 5.1.0

[pano9000]

This PR will supersede the automatically created one: #1586

Our code is already compliant with v5, and is not affected by the breaking changes described here: https://expressjs.com/en/guide/migrating-5.html

I ran their codemod command, and it did not find anything (except it strangely reformatted some unrelated code…).
So I also double-checked manually for all of the described changed topics in the migration guide.
→ nothing there :-)

with this change npm will still print a warning, due to @triliumnext/express-partial-content@"1.0.1", which needs to be updated to v5 as well, but the PR is raised TriliumNext/express-partial-content#1

once that is in, I will need to update that dependecy as well and we can get this merged.

target is: after the next stable, as confirmed here:
#1586 (comment)

[JYC333]

Merge the PR TriliumNext/express-partial-content#1. You can test this again I think.

[pano9000]

we will need a new released version on npm of that -> there is a CI action that will apparently do all of that, when there is a new tag created, however I don't want to "just do it" without @eliandoran having a final look over it :-)

[pano9000]

FYI: I've updated the @triliumnext/express-partial-content to 1.1.0 and can now do some actual testing:
I actually found out that their codemod does not check for the "Path route matching syntax" breaking change — and we actually have 2 occurrences here that are affected by it:

    apiRoute(PUT, "/api/options/:name/:value*", optionsApiRoute.updateOption);

and

    router.all("/custom/:path*", (req: Request, res: Response, _next) => {

the issue here is that the suggested way to migrate is not fully working with what I see we do on our end.

Express v4:

here we use
"/api/options/:name/:value*"

and when I trigger that via a PUT, and do some loggin of the req data (name and value), I see (e.g. here I changed locale to en):

params: {"0":"","name":"locale","value":"en"}

If I force additional paths in the PUT, it will only use the first path part as "value", e.g. with:
/api/options/locale/de/something/else

params: {"0":"/something/else","name":"locale","value":"de"}

Express v5:

here we are supposed to use /api/options/:name/*value and this gets us in trouble:
it gives us as req.params:

params: {"name":"locale","value":["de"]}

which results in an error, due to the value being in an array:

Updating option 'locale' to 'de'
Got error TypeError: SQLite3 can only bind numbers, strings, bigints, buffers, and null

same with me trying to add some fake paths as well:

params: {"name":"locale","value":["de","something","else"]}

Updating option 'locale' to 'de,something,else'
Got error TypeError: SQLite3 can only bind numbers, strings, bigints, buffers, and null

I'll work this week on getting these fixed and potentially do some extra testing on those other paths as well, just to make sure

[pano9000]

I have a "naive" working solution, but need chck and consider some edgecases (e.g. values with special characters -> URI encode them or not? I'll need to compare what v4 was doing and mimick accordingly)

some testing undergoing here still, should be back with an update this evening.

[github-actions]

Folder/File	Previous size	New size	Difference
/upload/TriliumNextNotes-Server-1626-merge-linux-x64.tar.xz		86.84MB	+86.84MB (+100.00%)
TOTAL			+86.84MB

[github-actions]

Folder/File	Previous size	New size	Difference
/upload/TriliumNextNotes-1626-merge-linux-x64.deb		139.34MB	+139.34MB (+100.00%)
/upload/TriliumNextNotes-1626-merge-linux-x64.flatpak		132.58MB	+132.58MB (+100.00%)
/upload/TriliumNextNotes-1626-merge-linux-x64.rpm		147.31MB	+147.31MB (+100.00%)
/upload/TriliumNextNotes-1626-merge-linux-x64.zip		178.29MB	+178.29MB (+100.00%)
TOTAL			+597.52MB

[pano9000]

marked PR as ready for review -> kindly also check my git commit messages for further info