Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: APPS 3110 Assemble Blog Listing page #101

Merged
merged 27 commits into from
Jan 30, 2025
Merged

feat: APPS 3110 Assemble Blog Listing page #101

merged 27 commits into from
Jan 30, 2025

Conversation

tinuola
Copy link
Contributor

@tinuola tinuola commented Jan 21, 2025 •
edited
Loading

Connected to APPS-3110

Page Created: /pages/blog/index.vue

Preview: https://deploy-preview-101--test-ftva.netlify.app/blog

Notes:

  • Connected ES search and assembled page components
  • Implemented infinite scroll
  • Added Cypress tests
  • Updated component library package to use BlockCardWithImage variant

Checklist:

  • I added github label for semantic versioning
  • I double checked it looks like the designs
  • I completed any required mobile breakpoint styling
  • I completed any required hover state styling
  • [ ] I included a working spec file
  • [ ] I added notes above about how long it took to build this component
  • UX has reviewed this PR
  • I have requested a PR review from the Dev team

@tinuola tinuola self-assigned this Jan 21, 2025
@github-actions GitHub Actions
Copy link
Contributor

Percy Screenshots

In order to conserve our percy screenshot allowance, percy is not configured to run automatically. Please make sure the PR is ready and all other checks are passing, then start it manually: 1. Visit https://github.com/UCLALibrary/ftva-website-nuxt/actions/workflows/percy.yml 2. Click the 'Run workflow' button in the blue bar. 3. Select the correct branch for this PR and click 'Run workflow' again to confirm.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 21, 2025 •
edited
Loading

🚀 Deployed on https://deploy-preview-101--test-ftva.netlify.app

@github-actions github-actions bot temporarily deployed to pull_request-101 January 21, 2025 21:23 Inactive
@github-actions github-actions bot temporarily deployed to pull_request-101 January 21, 2025 23:54 Inactive
@github-actions github-actions bot temporarily deployed to pull_request-101 January 22, 2025 03:19 Inactive
@github-actions github-actions bot temporarily deployed to pull_request-101 January 23, 2025 23:08 Inactive
@tinuola tinuola changed the title wip: APPS 3110 Assemble Blog Listing page feat: APPS 3110 Assemble Blog Listing page Jan 24, 2025
@github-actions github-actions bot temporarily deployed to pull_request-101 January 24, 2025 00:06 Inactive
@github-actions github-actions bot temporarily deployed to pull_request-101 January 25, 2025 01:03 Inactive
@github-actions github-actions bot temporarily deployed to pull_request-101 January 25, 2025 01:21 Inactive
@github-actions github-actions bot temporarily deployed to pull_request-101 January 28, 2025 22:53 Inactive
@github-actions github-actions bot temporarily deployed to pull_request-101 January 28, 2025 23:30 Inactive
@github-actions github-actions bot temporarily deployed to pull_request-101 January 28, 2025 23:42 Inactive
@github-actions github-actions bot temporarily deployed to pull_request-101 January 29, 2025 00:53 Inactive
@github-actions github-actions bot temporarily deployed to pull_request-101 January 29, 2025 01:03 Inactive
@tinuola tinuola force-pushed the APPS-3110_assemble-blog-listing-page branch from f967c89 to 56c98c2 Compare January 29, 2025 01:31
@github-actions github-actions bot temporarily deployed to pull_request-101 January 29, 2025 01:36 Inactive
jendiamond
jendiamond reviewed Jan 29, 2025
View reviewed changes
Copy link
Member

@jendiamond jendiamond left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the events that are in the featured blogs be included in the list below?

It looks great. 🍰

@github-actions github-actions bot temporarily deployed to pull_request-101 January 29, 2025 20:13 Inactive
@tinuola tinuola force-pushed the APPS-3110_assemble-blog-listing-page branch from 4b2598f to 3a0e936 Compare January 29, 2025 21:28
@github-actions github-actions bot temporarily deployed to pull_request-101 January 29, 2025 21:33 Inactive
pghorpade
pghorpade requested changes Jan 29, 2025
View reviewed changes
gql/queries/FTVAArticleList.gql Show resolved Hide resolved
pages/blog/index.vue Show resolved Hide resolved
pages/blog/index.vue Outdated Show resolved Hide resolved
@github-actions github-actions bot temporarily deployed to pull_request-101 January 30, 2025 00:48 Inactive
@github-actions github-actions bot temporarily deployed to pull_request-101 January 30, 2025 18:20 Inactive
pghorpade
pghorpade approved these changes Jan 30, 2025
View reviewed changes
Copy link
Contributor

@pghorpade pghorpade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 its good.

pages/blog/index.vue Show resolved Hide resolved
@tinuola tinuola merged commit 8fe0852 into main Jan 30, 2025
8 checks passed
@tinuola tinuola deleted the APPS-3110_assemble-blog-listing-page branch January 30, 2025 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jendiamond jendiamond jendiamond left review comments

@pghorpade pghorpade pghorpade approved these changes

Assignees

@tinuola tinuola

Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tinuola @jendiamond @pghorpade