Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: APPS 3110 Assemble Blog Listing page #101

Merged
merged 27 commits into from
Jan 30, 2025
Merged
Show file tree
Hide file tree
Changes from 21 commits
Commits
Show all changes
27 commits
Select commit Hold shift + click to select a range
5468c3d
wip
tinuola Jan 16, 2025
81a7b08
wip
tinuola Jan 21, 2025
2a03172
wip: update logic for data images; adjust page styling
tinuola Jan 21, 2025
c303976
fix: parse article categories
tinuola Jan 22, 2025
d8ca7f8
wip: fix infinite scrolling
tinuola Jan 23, 2025
e6774f8
task: code cleanup
tinuola Jan 23, 2025
1b01296
update: add displaySummary field to article gql
tinuola Jan 24, 2025
d056cf7
test: add basic cypress test
tinuola Jan 24, 2025
8b9479a
wip: add pageSummary toggle logic
tinuola Jan 24, 2025
2196966
task: update component library to 3.45.0
tinuola Jan 24, 2025
6aefb97
add BlockCard ftva variant
tinuola Jan 25, 2025
1fe6f0e
fix: linting, remove v-html directive
tinuola Jan 25, 2025
f9b9645
update library package to 3.45.1
tinuola Jan 28, 2025
f2105ba
update CSS after component pkg update
tinuola Jan 28, 2025
003323c
Add more conditions to cypress test
tinuola Jan 28, 2025
95304c8
fix: remove custom rich-text padding-right
tinuola Jan 28, 2025
46d5ef8
remove console statements
tinuola Jan 28, 2025
318c03d
fix: ux/css updates
tinuola Jan 29, 2025
d73cc66
update query to incl. categories for featured artciles
tinuola Jan 29, 2025
9b5bf9f
fix: display featured articles' categories
tinuola Jan 29, 2025
56c98c2
fix: add page SectionHeaders with h3
tinuola Jan 29, 2025
34e7a42
fix: remove unneeded css values
tinuola Jan 29, 2025
3a0e936
update featured blogs section title on mobile
tinuola Jan 29, 2025
1d0895f
update featuredArticles query with alternativeTitle field
tinuola Jan 29, 2025
8520f2d
add logic to parse alternate richtext featuredArticle title
tinuola Jan 30, 2025
2f57816
Merge branch 'main' into APPS-3110_assemble-blog-listing-page
jendiamond Jan 30, 2025
e1ad66f
update preview watcher to track pageTitle
tinuola Jan 30, 2025
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 31 additions & 0 deletions cypress/e2e/blogListPage.cy.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,31 @@
Cypress.on('uncaught:exception', () => { return false })

describe('Blog Listing page', () => {
beforeEach(() => {
cy.visit('/blog')
})

it('Visits Blog Listing page', () => {
cy.getByData('blog-page-title').should('be.visible')

cy.getByData('featured-blog-0').should('be.visible')

cy.getByData('featured-blog-1').should('be.visible')

cy.getByData('featured-blog-2').should('be.visible')

cy.getByData('latest-blogs').should('be.visible')

cy.percySnapshot('eventslistpage', { widths: [768, 992, 1200] })
})

it('Shows only one featured blog in mobile view', () => {
cy.viewport(750, 720)

cy.getByData('featured-blog-0').should('be.visible')

cy.getByData('featured-blog-1').should('not.be.visible')

cy.getByData('featured-blog-2').should('not.be.visible')
})
})
4 changes: 4 additions & 0 deletions gql/queries/FTVAArticleList.gql
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,13 @@ query FTVAArticleList($slug: [String!]) {
sectionHandle
title: titleGeneral
summary
displaySummary
ftvaFeaturedArticles {
title
tinuola marked this conversation as resolved.
Show resolved Hide resolved
postDate
articleCategories {
title
}
ftvaHomepageDescription
uri
ftvaImage {
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@
"nuxt-graphql-request": "^7.0.5",
"sass": "^1.66.1",
"ucla-library-design-tokens": "^5.28.0",
"ucla-library-website-components": "3.43.7"
"ucla-library-website-components": "3.45.1"
},
"engines": {
"pnpm": "^9.12.1"
Expand Down
Loading
Loading