Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/illumina samplesheet v2 #77

Merged
merged 20 commits into from
Feb 23, 2024
Merged

Conversation

rernst
Copy link
Member

@rernst rernst commented Jan 22, 2024

  • Add support for illumina samplesheet v2
    • Replace samplesheet update with create samplesheet.

Copy link
Contributor

@ellendejong ellendejong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most comments reflect differences in coding style.
I would like to see get_samplesheet_samples refactored.

@rernst rernst requested a review from ellendejong February 12, 2024 16:33
Comment on lines 365 to 366
print(total_sample_count)
print(input_pools)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Print statement necessary?

ellendejong
ellendejong previously approved these changes Feb 23, 2024
@rernst rernst merged commit 97a16df into develop Feb 23, 2024
1 check passed
@rernst rernst deleted the feature/illumina_samplesheet_v2 branch February 23, 2024 08:36
@rernst rernst mentioned this pull request Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants