This repository was archived by the owner on Jun 28, 2025. It is now read-only.
Dependency injection #65
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-3.5 into Dependency-Injection
Yaremadzulynsky
commented
Oct 27, 2024
Contributor
Author
Yaremadzulynsky
left a comment
Yaremadzulynsky
left a comment
There was a problem hiding this comment.
Great work!
Contributor
Author
There was a problem hiding this comment.
Awesome. One note I have is that the SM constructor is starting to look a little cluttered with TM stuff. What we could do is make a function in the SM cpp file called something like setupTM() which will do the TM setup stuff, then call tm->init() after everything is set up.
larry-pan
force-pushed
the
Dependency-Injection
branch
from
d728939 to
58ebab6
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What was completed, changed, or updated?
All dependency objects used by TelemetryManager (e.g. GroundStationCommunication) are now created in SystemManager before the TM object. Dependencies are passed directly to the TM constructor.
All state data pointers used by TM have been organized to a struct.
Why was this done (if applicable)?
TM can now be created from mock instances for testing.
The order of object construction can be changed, so we can wait until we have all dependencies ready before initializing a TM object.
TM objects can potentially be made outside of SystemManager
Testing
What unit tests were used to validate the code?
Documentation
Milestone number and name:
M3
Link to Asana task: https://app.asana.com/0/1203458353737758/1208312402823490/f
Reminders
Add reviewers to the PR
Mention the PR in the appropriate discord channel