This repository was archived by the owner on Jun 28, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 9
Dependency injection #65
Merged
Merged
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
42e67f6
Dependency Injection for GroundStationCommunication
larry-pan 9feb0ac
Added MT Dependency Injection and StateData struct
larry-pan f96b272
Pointers for stateData
larry-pan 4158d3b
fixed pointer bug
larry-pan 43268eb
fixed typos
larry-pan e5ef4db
Fixed initialization of stateData
larry-pan a364104
test
larry-pan f6db75b
Changed name StateData to TMStateData
larry-pan 426f322
Dependency Injection for GroundStationCommunication (#64)
larry-pan a5bb017
Merge branch 'Dependency-Injection' of github.com:UWARG/efs-zeropilot…
larry-pan 0167ac3
Rename state and mode to mavState and mavMode
larry-pan 08d112a
fixed typo
larry-pan 5903200
Merge branch 'main' into Dependency-Injection
Yaremadzulynsky 56825cc
Added protection against dereferencing nullptr in TMStateData obj
Yaremadzulynsky 58ebab6
add setupTM
larry-pan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome. One note I have is that the SM constructor is starting to look a little cluttered with TM stuff. What we could do is make a function in the SM cpp file called something like setupTM() which will do the TM setup stuff, then call tm->init() after everything is set up.