Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Richard H - Completed GS onboarding task #5

Closed
wants to merge 4 commits into from
Closed

Richard H - Completed GS onboarding task #5

wants to merge 4 commits into from

Conversation

wabarurse
Copy link

Purpose

Completed the GS onboarding backend tasks.

New Changes

  • Implemented data validation for commands in backend/data/data_models.py
  • Implemented post endpoint for commands in backend/endpoints/command.py
  • Implemented delete endpoint for commands in backend_endpoints/command.py
  • Implemented logger middleware in backend/api/middlewares/logger_middleware.py

Yarik-Popov
Yarik-Popov requested changes Jan 21, 2025
View reviewed changes
Copy link
Contributor

@Yarik-Popov Yarik-Popov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great start. Some very minor changes to make it perfect

backend/api/middlewares/logger_middleware.py Outdated Show resolved Hide resolved
backend/api/middlewares/logger_middleware.py Outdated Show resolved Hide resolved
backend/data/data_models.py Outdated Show resolved Hide resolved
backend/api/middlewares/logger_middleware.py Outdated Show resolved Hide resolved
backend/data/data_models.py Outdated Show resolved Hide resolved
Yarik-Popov
Yarik-Popov requested changes Jan 21, 2025
View reviewed changes
Copy link
Contributor

@Yarik-Popov Yarik-Popov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some small changes for the middleware left. One change is to fix a potential crashing situation

backend/api/middlewares/logger_middleware.py Outdated Show resolved Hide resolved
backend/api/middlewares/logger_middleware.py Outdated Show resolved Hide resolved
@wabarurse wabarurse requested a review from Yarik-Popov January 22, 2025 16:02
Yarik-Popov
Yarik-Popov requested changes Jan 22, 2025
View reviewed changes
Copy link
Contributor

@Yarik-Popov Yarik-Popov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be last set of change. They are related to our naming & import conventions

backend/api/middlewares/logger_middleware.py Outdated Show resolved Hide resolved
backend/api/middlewares/logger_middleware.py Outdated Show resolved Hide resolved
backend/api/middlewares/logger_middleware.py Outdated Show resolved Hide resolved
Yarik-Popov
Yarik-Popov reviewed Jan 23, 2025
View reviewed changes
Copy link
Contributor

@Yarik-Popov Yarik-Popov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm. Congrats, you are done the gs onboarding

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yarik-Popov Yarik-Popov Yarik-Popov requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wabarurse @Yarik-Popov