Richard H - Completed GS onboarding task

backend/api/endpoints/command.py

@@ -24,23 +24,40 @@ def get_commands(db: Session = Depends(get_db)):
 
 
 @command_router.post("/", response_model=CommandSingleResponse)
-def create_command(payload: CommandRequest):
+def create_command(payload: CommandRequest, db: Session = Depends(get_db)):
     """
     Creates an item with the given payload in the database and returns this payload after pulling it from the database 
 
     @param payload: The data used to create an item
     @return returns a json object with field of "data" under which there is the payload now pulled from the database 
     """
-    # TODO:(Member) Implement this endpoint
-
+
+    new_command = Command(**payload.dict());
+
+    db.add(new_command)
+    db.commit()
+    db.refresh(new_command)
+
+    return {"data" : new_command}
 
 
 @command_router.delete("/{id}", response_model=CommandListResponse)
-def delete_command(id: int):
+def delete_command(id: int, db: Session = Depends(get_db)):
     """
     Deletes the item with the given id if it exists. Otherwise raises a 404 error.
 
     @param id: The id of the item to delete
     @return returns the list of commands after deleting the item
     """
-    # TODO:(Member) Implement this endpoint
+
+    command_to_delete = db.get(Command, id)
+    if not command_to_delete:
+        raise HTTPException(status_code=404)
+
+    db.delete(command_to_delete)
+    db.commit()
+
+    remaining_commands = db.exec(select(Command)).all()
+
+    return {"data": remaining_commands}
+

backend/api/middlewares/logger_middleware.py

@@ -1,8 +1,12 @@
 from collections.abc import Callable
+from time import time 
 from typing import Any
 from fastapi import Request, Response
+from loguru import logger
 from starlette.middleware.base import BaseHTTPMiddleware
 
+from backend.utils.logging import logger_setup, logger_close
+
 
 class LoggerMiddleware(BaseHTTPMiddleware):
     async def dispatch(
@@ -17,6 +21,28 @@ async def dispatch(
         @param call_next: Endpoint or next middleware to be called (if any, this is the next middleware in the chain of middlewares, it is supplied by FastAPI)
         @return Response from endpoint
         """
-        # TODO:(Member) Finish implementing this method
-        response = await call_next(request)
-        return response
+
+        #logger_setup() assuming this is run during startup
+
+        logger.info(f"Incoming request: {request.method} {request.url.path}");
+        logger.info(f"Params: {request.query_params}");
+        logger.info(f"Headers: {dict(request.headers)}");
+
+        try:
+            start_time = time()
+            response = await call_next(request)
+            end_time = time() - start_time
+
+            logger.info(f"Outgoing response: {request.method} {request.url.path}")
+            logger.info(f"Response status: {response.status_code}")
+            logger.info(f"Response headers: {dict(response.headers)}")
+            logger.info(f"Response time: {end_time}")
+
+            #await logger_close()
+            return response
+
+        except Exception as e:
+            #await logger_close()
+            raise
+
+

backend/data/data_models.py

@@ -33,7 +33,12 @@ def validate_params_format(self):
         The format of the comma seperated values is "data1,data2" so no spaces between data and the commas.
         """
         # TODO: (Member) Implement this method
-        return self
+        if not self.params and not self.format:
+            return self
+        elif self.params and self.format and len(self.params.split(",")) == len(self.format.split(",")):
+            return self
+        else:
+            raise ValueError
 
 
 class Command(BaseSQLModel, table=True):