[TF2] Fix disguise_on_backstab not functioning for stab targets that become ghosts #1279
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…D_HALLOWEEN_IN_HELL or TF_COND_HALLOWEEN_GHOST_MODE
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes ValveSoftware/Source-1-Games#4477
Players with cond TF_COND_HALLOWEEN_IN_HELL do not change m_lifeState when they are killed, instead gaining TF_COND_HALLOWEEN_GHOST_MODE; the IsAlive() check used in successful backstab checks solely looks at lifestate, so backstabs on these players are never considered successful despite causing their 'death'. This fixes the check to account for GHOST_MODE.
Tested that the player properly obtains GHOST_MODE in time for the check when stabbed with IN_HELL.