Fix class select animation playback

[brokenparts]

Hi. This fixes a bug where class select animations will freeze if you go back and forth in the menu.

Related issues:

• [TF2] Class selection screen animations and sound effects are broken  Source-1-Games#4121
• [TF2] Class select screen animation delay Source-1-Games#2116

Before

fix-class-select-anims-before.mp4

After

fix-class-select-anims-after.mp4

Details

When reusing the shared CTFPlayerModelPanel in the class select screen, SetupFlexWeights would incorrectly calculate a large negative m_flSceneTime. This would result in class select animations freezing when going back and forth in the class select menu.

-0.1s start times are allowed to give the system time to lerp to the looping animation. This constant is already used in neighboring code.

The 2nd commit just replaces this 0.1f magic number with a macro constant. This is optional, I just thought it would be a nice improvement.

[condor00fr]

Finally someone has adresse this! Is there any ways the sound effects could be re-introduced as well?

[num-get]

There's also another bug where the player models have their mouth wide open and then slowly decay to neutral expression for over a second when you select them.

source-sdk-2013/src/game/client/tf/vgui/tf_playermodelpanel.cpp

Line 2261 in 39f6dde

SetFlexWeight( i, GetFlexWeight( i ) * 0.95 );

You could fix it by simply changing the number from 0.95 to 0.0f.