Skip to content

Conversation

@muster128
Copy link

Reflected Rescue Ranger bolts now heal buildings that are on the same team as the reflector.

Description

@wgetJane
Copy link
Contributor

wgetJane commented Jan 4, 2026

looks good (other than not fitting valve's whitespace style) but i personally think similar reflect bugs should be factored in

see: #1733 (comment)

im not really sure how to go about this other than a big pr that consolidates related fixes, idk if that's the right approach or not

@muster128
Copy link
Author

I'm not totally sure either. I was told that PRs should focus on one single topic, and this and the grenade bug might be different enough to qualify as separate issues. Maybe there should be a GetOriginalProjectileCreator() function to CBaseProjectile, which could help with both issues?
Is there a guide on code styling requirements I can look up? This is my first time trying to make TF2 changes like this, so I'm a little out of my depth.

@wgetJane
Copy link
Contributor

wgetJane commented Jan 5, 2026

imo maybe move the definition to the base tf2 projectile class instead of just the arrow projectile

Is there a guide on code styling requirements I can look up? This is my first time trying to make TF2 changes like this, so I'm a little out of my depth.

there isn't really a style guide, but the rest of code base has a space after an opening parenthesis and a space before a closing parenthesis

so this:

if (!pOriginalAttacker)

should be like this:

if ( !pOriginalAttacker )

…ow used in tf_projectile_arrow for reflected Rescue Ranger bolts
@muster128
Copy link
Author

Made a new commit where I expose GetAttackerEntity() as a public member function. Does this work better?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants