Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Workflow:
cp_process_singlecells
! #37New Workflow:
cp_process_singlecells
! #37Changes from 29 commits
74f9959
fbd9ffa
86e6f7d
d4f6794
91e4014
e90b18a
fe16359
54b2009
24aa53c
febe581
6003d11
6115dc5
1608de2
8a36504
a6dc5fb
c0b7460
ceb0094
74fd4cb
c9e206c
1f71e1c
fabe130
e87aa56
c22ba5b
d7f4157
a3104e8
be045dc
b2e92e2
8e0475c
bcd92de
fecfb6f
df8a863
1ebd569
9d00a7a
3d6fbf4
8413984
7a1a22d
c75ad28
4970d85
a0e42cd
69294d8
f2e9c12
6f4a7f6
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is probably beyond scope of
cytosnake
, but can you specify non-canonical compartments? (e.g. anything beyond Cells, Cytoplasm, and Nuclei)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will depend on
CytoTable
's capability. The config files will take anything as long as the parameters are valid inCytoTable
'sconvert
workflow. Therefore, if there is support for non-canonical compartments withinCytoTable
then it should work?Looking at the documentation, the
join
parameter only takes a boolean.Correct me if I am wrong @d33bs.This will depend on
CytoTable
's capability. The config files will take anything as long as the parameters are valid inCytoTable
'sconvert
workfow. Therefore, if there is support for non-cononical compartments withinCytoTable
then it should work?Looking at the documentation, the
join
parameter only takes a boolean.Correct me if I am wrong @d33bs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@axiomcura -
CytoTable.convert
'sjoin
parameter decides whether the conversion should perform compartment merge (or solely concatenation viaconcat
). Additional or different compartments may be specified via thecompartments
parameter. See the configuration presets here for a reference of example parameters used by CytoTable. Does the configuration found here for CytoSnake enable the use of the CytoTablecompartments
parameter?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be updated somehow? I wasn't certain how this would effect the return of this function (would it product
".../{file_name}.parquet"
every time?).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, now looking in retrospect, the helper functions are not well developed as it takes in too much repeated code.
Will be creating a PR for this issue: #32
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider using only an f-string to format this string to help increase readability.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will be updated in the future! #32
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if you change the name of the this file above, also make sure to propagate the change here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Correct. Any name changes that occurs will also have to be reflected here. Still thinking on ideas on how to prevent harcoding file names. I am open to any suggestions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think it is ok to hardcode some things - ultimately, they will need to be hardcoded somewhere!
You may consider having a single function where these names are hardcoded, and calling the function wherever hardcodes are used. Just don't update the corresponding dictionary keys!
I think what you have now is fine.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was thinking of making a
class
the handles all the file pathing function calls. It's an idea.