Skip to content

GitHub Actions: Python 3.x #233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 13, 2025
Merged

GitHub Actions: Python 3.x #233

Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
faa4607
GitHub Actions: Python 3.9 and 3.13
cclauss Mar 6, 2025
2d73f57
3.8 is the oldest Python supported by validate-pyproject
cclauss Mar 6, 2025
b565c9b
Py3.12 is required
cclauss Mar 7, 2025
4a6365e
Merge branch 'main' into patch-1
cclauss Mar 10, 2025
64c3c55
Update .github/workflows/ci.yml
henryiii Mar 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,8 +65,9 @@ jobs:
strategy:
matrix:
python:
- "3.8" # oldest Python supported by PSF
- "3.12" # newest Python that is stable
- "3.8" # oldest Python supported by validate-pyproject
- "3.12" # This must remain because Py3.12 is hardcoded to block all other tests
- "3.x" # newest Python that is stable
Copy link
Collaborator

@henryiii henryiii Mar 13, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@abravalheri, personally, I prefer listing this explicitly (3.13), then updating it as soon as a beta comes out (leaving allow-prereleases: true). But that's also because I list the Python versions in trove classifiers, and once it passes for the first beta is the point I declare support for the new version. If you don't list versions you test on as classifiers, this seems fine.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much @henryiii for assessing this.
I tend to simplify as much as I can the classifiers (I am not using them for the time being to record which versions the project is tested).

In the future we can change that if required.

Also open to have allow-prereleases: true (as long as we don't require the pre-releases to pass). But we probably can have that in a separated PR if there is anyone in the community interested in that.

For the time being the GHA CI is kept very lightweight the bulk of testing happens on cirrus (also open to review that if required).

platform:
- ubuntu-latest
- macos-13
Expand Down
Loading