Own classes for both Literal and Iri
#1301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Next step: Also return proper IRIs from the SPARQL parser.
Next step: Fold the blank nodes into the ID.
# Conflicts: # src/engine/IndexScan.cpp # src/index/VocabularyGenerator.h # src/parser/sparqlParser/SparqlQleverVisitor.cpp # test/QueryPlannerTest.cpp # test/SparqlExpressionTest.cpp # test/SparqlExpressionTestHelpers.h
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1301 +/- ##
==========================================
- Coverage 88.24% 88.10% -0.15%
==========================================
Files 310 313 +3
Lines 28432 28503 +71
Branches 3148 3155 +7
==========================================
+ Hits 25091 25112 +21
- Misses 2188 2235 +47
- Partials 1153 1156 +3 ☔ View full report in Codecov by Sentry. |
# Conflicts: # CMakeLists.txt
TODO<joka921> There is still quite some cleaning up todo.
hannahbast
reviewed
Mar 20, 2024
hannahbast
requested changes
Mar 21, 2024
hannahbast
changed the title
LiteralOrIri type as part of the TripleComponent class.Literal and Iri
hannahbast
requested changes
Mar 21, 2024
hannahbast
changed the title
Literal and IriLiteral and Iri
hannahbast
approved these changes
Mar 22, 2024
|
hannahbast
pushed a commit
that referenced
this pull request
Mar 23, 2024
Since #1301, triples were the subject is an explicit blank node (for example `_:x <is-a> <blankNode>.`) could no longer be parsed. This commit fixes this bug and adds a unit test for this case.
hannahbast
pushed a commit
that referenced
this pull request
May 3, 2024
#1301 introduced a bug where basic graph patterns like `wdt:Q183 ?p ?o` (fixed subject or object with a language tag, variable predicate) throw an exception. This is now fixed again.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So far, literals and IRIs were stored as a
std::string(in a normalized way, that is, without escaping) and the distinction between literals and IRIs was made via the first character ("or<). The code to deal with datatypes (the stuff after^^) and language tags (e.g.,@en) was also ad-hoc using low-level string operations. Now there are proper classesLiteralandIri, which internally still store their data as normalized strings starting with"or<(just like before), but they are now two different types and each with a proper interface. This continues work started with #1186.The new classes are used in the
TripleComponentclass, which is used by the Turtle and SPARQL parsers. As a consequence, a lot of code is affected by this change. The new classes are not yet used byLocalVocabandExportQueryExecutionTrees.