Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Own classes for both Literal and Iri #1301

Merged
merged 33 commits into from
Mar 22, 2024

Some improvements from a review with Hannah.

f43dff9
Select commit
Loading
Failed to load commit list.
Merged

Own classes for both Literal and Iri #1301

Some improvements from a review with Hannah.
f43dff9
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Mar 21, 2024 in 0s

87.94% (-0.17%) compared to 0c0d27a

View this Pull Request on Codecov

87.94% (-0.17%) compared to 0c0d27a

Details

Codecov Report

Attention: Patch coverage is 95.77922% with 13 lines in your changes are missing coverage. Please review.

Project coverage is 87.94%. Comparing base (0c0d27a) to head (f43dff9).
Report is 3 commits behind head on master.

❗ Current head f43dff9 differs from pull request most recent head 10136b1. Consider uploading reports for the commit 10136b1 to get more accurate results

Files Patch % Lines
src/parser/TurtleParser.cpp 91.07% 4 Missing and 1 partial ⚠️
src/parser/Literal.cpp 94.33% 2 Missing and 1 partial ⚠️
src/engine/sparqlExpressions/LiteralExpression.h 85.71% 1 Missing and 1 partial ⚠️
src/index/IndexImpl.cpp 96.29% 0 Missing and 1 partial ⚠️
src/parser/TripleComponent.h 92.85% 0 Missing and 1 partial ⚠️
src/parser/sparqlParser/SparqlQleverVisitor.cpp 94.11% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #1301      +/-   ##
==========================================
- Coverage   88.10%   87.94%   -0.17%     
==========================================
  Files         310      313       +3     
  Lines       28444    28515      +71     
  Branches     3150     3157       +7     
==========================================
+ Hits        25061    25077      +16     
- Misses       2231     2283      +52     
- Partials     1152     1155       +3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov