Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fail rendering when variant product data is null #14

Merged
merged 6 commits into from
Jan 16, 2025
Merged

Fail rendering when variant product data is null #14

merged 6 commits into from
Jan 16, 2025

Conversation

herzog31
Copy link
Member

  • In rare cases, Catalog Service might not return product data as part of the variants query. This typically happens during a product sync.
  • In these cases the rendering action should fail, so it will be retried by the poller after some time. The action will return a HTTP 500 error and log the error.
  • Updated unit tests.

Merge after #12.

@herzog31 herzog31 added the do not merge Please do not merge! label Jan 15, 2025
@herzog31 herzog31 mentioned this pull request Jan 15, 2025
Merged
Base automatically changed from SITES-27868 to main January 16, 2025 10:24
@herzog31 herzog31 merged commit 8f88c76 into main Jan 16, 2025
1 check passed
@herzog31 herzog31 deleted the SITES-28175 branch January 16, 2025 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dicagno dicagno dicagno approved these changes

@duynguyen duynguyen Awaiting requested review from duynguyen

@hannessolo hannessolo Awaiting requested review from hannessolo

Assignees
No one assigned
Labels
do not merge Please do not merge!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@herzog31 @dicagno