Fail rendering when variant product data is null

actions/pdp-renderer/index.js

@@ -62,7 +62,7 @@ async function main (params) {
     const contentUrl = __ow_query?.contentUrl || HLX_CONTENT_URL;
     const storeUrl = __ow_query?.storeUrl || HLX_STORE_URL || contentUrl;
     const productsTemplate = __ow_query?.productsTemplate || HLX_PRODUCTS_TEMPLATE;
-    const context = { contentUrl, storeUrl, configName };
+    const context = { contentUrl, storeUrl, configName, logger };
 
     if (!sku || !contentUrl) {
       return errorResponse(400, 'Invalid path', logger);

actions/pdp-renderer/ldJson.js

@@ -27,10 +27,16 @@ function getOffer(product, url) {
 }
 
 async function getVariants(baseProduct, url, axes, context) {
+  const { logger } = context;
   const variantsData = await requestSaaS(VariantsQuery, 'VariantsQuery', { sku: baseProduct.sku }, context);
   const variants = variantsData.data.variants.variants;
 
   return variants.map(variant => {
+    if (!variant.product) {
+      logger.error(`Variant of product ${baseProduct?.sku} is null. Variant data is not correctly synchronized.`, variant);
+      throw new Error('Product variant is null');
+    }
+
     const variantImage = getPrimaryImage(variant.product, null);
     const variantUrl = new URL(url);
     variantUrl.searchParams.append('optionsUIDs', variant.selections.sort().join(','));

test/ldJson.test.js

@@ -10,14 +10,20 @@ OF ANY KIND, either express or implied. See the License for the specific languag
 governing permissions and limitations under the License.
 */
 
+const { graphql, HttpResponse } = require('msw');
+
 const { generateLdJson } = require('../actions/pdp-renderer/ldJson');
 const { useMockServer, handlers } = require('./mock-server.js');
 
 describe('ldJson', () => {
 
-    const mockContext = { contentUrl: 'https://content.com', storeUrl: 'https://example.com', configName: 'config' };
+    const mockContext = { contentUrl: 'https://content.com', storeUrl: 'https://example.com', configName: 'config', logger: { error: jest.fn() } };
     const server = useMockServer();
 
+    beforeEach(() => {
+        mockContext.logger.error.mockClear();
+    });
+
     test('generate ldJson for simple product', async () => {
         const product = {
             __typename: 'SimpleProductView',
@@ -164,4 +170,44 @@ describe('ldJson', () => {
         const context = {};
         await expect(generateLdJson(product, context)).rejects.toThrow('Unsupported product type');
     });
+
+    test('fail for null variant', async () => {
+        const product = {
+            __typename: 'ComplexProductView',
+            name: 'Complex Product',
+            sku: 'complex-sku',
+            urlKey: 'complex-product',
+            shortDescription: 'short description',
+            metaDescription: 'meta description',
+            description: 'full description',
+            options: [
+                { id: 'color' },
+                { id: 'size' }
+            ],
+            priceRange: {},
+            inStock: true,
+            images: [
+                { url: 'image1.jpg', roles: ['image'] }
+            ]
+        };
+
+        server.use(graphql.query('VariantsQuery', () => HttpResponse.json({
+            data: {
+                variants: {
+                    variants: [
+                        {
+                            selections: [
+                                'color-green',
+                                'size-l'
+                            ],
+                            product: null
+                        }
+                    ]
+                }
+            }
+        })));
+
+        await expect(generateLdJson(product, mockContext)).rejects.toThrow('Product variant is null');
+        expect(mockContext.logger.error).toHaveBeenCalled();
+    })
 });