Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(checkbox): update box color to neutral in s2 #3573

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

TarunAdobe
Copy link
Contributor

@TarunAdobe TarunAdobe commented Feb 24, 2025

Description

Update deselected border color of checkbox to neutral.
SWC-498

How and where has this been tested?

Please tag yourself on the tests you've marked complete to confirm the tests have been run by someone other than the author.

Validation steps

Regression testing

Validate:

  1. The documentation pages for at least two other components are still loading, including:
  • The pages render correctly, are accessible, and are responsive.
  1. If components have been modified, VRTs have been run on this branch:
  • VRTs have been run and looked at.
  • Any VRT changes have been accepted (by reviewer and/or PR author), or there are no changes.

Screenshots

To-do list

  • I have read the contribution guidelines.
  • I have updated relevant storybook stories and templates.
  • I have tested these changes in Windows High Contrast mode.
  • If my change impacts other components, I have tested to make sure they don't break.
  • If my change impacts documentation, I have updated the documentation accordingly.
  • ✨ This pull request is ready to merge. ✨

Copy link

changeset-bot bot commented Feb 24, 2025

🦋 Changeset detected

Latest commit: 0665550

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@spectrum-css/checkbox Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@TarunAdobe TarunAdobe marked this pull request as ready for review February 24, 2025 10:36
Copy link
Contributor

github-actions bot commented Feb 24, 2025

File metrics

Summary

Total size: 2.25 MB*

Package Size Minified Gzipped
checkbox 22.43 KB 21.35 KB 2.56 KB

checkbox

Filename Head Minified Gzipped Compared to base
index-base.css 22.03 KB 20.97 KB 2.52 KB -
index-theme.css 1.14 KB 1.12 KB 0.51 KB -
index.css 22.43 KB 21.35 KB 2.56 KB 🔴 ⬆ 0.02 KB
metadata.json 12.69 KB - - 🟢 ⬇ 0.03 KB
themes/express.css 1.04 KB 1.01 KB 0.51 KB -
themes/spectrum-two.css 1.01 KB 1.01 KB 0.52 KB 🔴 ⬆ 0.02 KB
themes/spectrum.css 1.04 KB 1.01 KB 0.52 KB -
* Size is the sum of all main files for packages in the library.
* An ASCII character in UTF-8 is 8 bits or 1 byte.

Copy link
Contributor

github-actions bot commented Feb 24, 2025

🚀 Deployed on https://pr-3573--spectrum-css.netlify.app

@castastrophe
Copy link
Collaborator

@TarunAdobe Can you please update the branch with the base branch and write out a few validation test cases in the pull request template for us to confirm the updates?

@castastrophe castastrophe added size-2 S ~6-18hrs; not hard or time consuming, one or two work days to complete. run_vrt For use on PRs looking to kick off VRT ready-for-review high priority An important PR or issue requiring immediate attention fast-follows An issue or PR that quickly follows a release labels Feb 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fast-follows An issue or PR that quickly follows a release high priority An important PR or issue requiring immediate attention ready-for-review run_vrt For use on PRs looking to kick off VRT size-2 S ~6-18hrs; not hard or time consuming, one or two work days to complete.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants