Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MWPW-159427: Milo Catalog: Ipad specific issues #422

Closed
wants to merge 4 commits into from

Conversation

mirafedas
Copy link
Contributor

@mirafedas mirafedas commented Oct 2, 2024

On iOS version 15 and lower there is a different way of managing the vertical stacking context, which puts the modal below the merch card. Adding z-index on the merch-sidenav resolves this problem.

Related Milo PR: adobecom/milo#2994

Resolves: MWPW-159427

Test URLs:

For PSI check:
https://mwpw-159427-ipad-issues--milo--mirafedas.hlx.live/?martech=off&georouting=off

Copy link

aem-code-sync bot commented Oct 2, 2024

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

Copy link

aem-code-sync bot commented Oct 2, 2024

Page Scores Audits Google
📱 /?martech=off&georouting=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
🖥️ /?martech=off&georouting=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@milo-pr-merge-cc
Copy link

Skipped merging 422: MWPW-159427: Milo Catalog: Ipad specific issues due to missing verified label. kindly make sure that the PR has been verified

@Axelcureno
Copy link
Member

why is the only change is in minified file?

@aem-code-sync aem-code-sync bot temporarily deployed to mwpw-159427-ipad-issues October 3, 2024 09:26 Inactive
@mirafedas
Copy link
Contributor Author

mirafedas commented Oct 3, 2024

@Axelcureno every time when we make a change in merch-sidenav on Milo, we need to update the minified merch-sidenav in CC to keep it up to date. Here is the respective Milo PR: adobecom/milo#2994

@milo-pr-merge-cc
Copy link

Skipped merging 422: MWPW-159427: Milo Catalog: Ipad specific issues due to missing verified label. kindly make sure that the PR has been verified

2 similar comments
@milo-pr-merge-cc
Copy link

Skipped merging 422: MWPW-159427: Milo Catalog: Ipad specific issues due to missing verified label. kindly make sure that the PR has been verified

@milo-pr-merge-cc
Copy link

Skipped merging 422: MWPW-159427: Milo Catalog: Ipad specific issues due to missing verified label. kindly make sure that the PR has been verified

@milo-pr-merge-cc
Copy link

Skipped merging 422: MWPW-159427: Milo Catalog: Ipad specific issues due to missing verified label. kindly make sure that the PR has been verified

4 similar comments
@milo-pr-merge-cc
Copy link

Skipped merging 422: MWPW-159427: Milo Catalog: Ipad specific issues due to missing verified label. kindly make sure that the PR has been verified

@milo-pr-merge-cc
Copy link

Skipped merging 422: MWPW-159427: Milo Catalog: Ipad specific issues due to missing verified label. kindly make sure that the PR has been verified

@milo-pr-merge-cc
Copy link

Skipped merging 422: MWPW-159427: Milo Catalog: Ipad specific issues due to missing verified label. kindly make sure that the PR has been verified

@milo-pr-merge-cc
Copy link

Skipped merging 422: MWPW-159427: Milo Catalog: Ipad specific issues due to missing verified label. kindly make sure that the PR has been verified

@milo-pr-merge-cc
Copy link

Skipped merging 422: MWPW-159427: Milo Catalog: Ipad specific issues due to missing verified label. kindly make sure that the PR has been verified

Copy link
Contributor

@yesil yesil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you clarify why merch-sidenav is still needed on cc w.r.t #412 (review) ?

@mirafedas
Copy link
Contributor Author

Closing because the needed change will be added in the #412

@mirafedas mirafedas closed this Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants