-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MWPW-159427: Milo Catalog: Ipad specific issues #422
Conversation
|
Skipped merging 422: MWPW-159427: Milo Catalog: Ipad specific issues due to missing verified label. kindly make sure that the PR has been verified |
why is the only change is in minified file? |
@Axelcureno every time when we make a change in merch-sidenav on Milo, we need to update the minified merch-sidenav in CC to keep it up to date. Here is the respective Milo PR: adobecom/milo#2994 |
Skipped merging 422: MWPW-159427: Milo Catalog: Ipad specific issues due to missing verified label. kindly make sure that the PR has been verified |
2 similar comments
Skipped merging 422: MWPW-159427: Milo Catalog: Ipad specific issues due to missing verified label. kindly make sure that the PR has been verified |
Skipped merging 422: MWPW-159427: Milo Catalog: Ipad specific issues due to missing verified label. kindly make sure that the PR has been verified |
Skipped merging 422: MWPW-159427: Milo Catalog: Ipad specific issues due to missing verified label. kindly make sure that the PR has been verified |
4 similar comments
Skipped merging 422: MWPW-159427: Milo Catalog: Ipad specific issues due to missing verified label. kindly make sure that the PR has been verified |
Skipped merging 422: MWPW-159427: Milo Catalog: Ipad specific issues due to missing verified label. kindly make sure that the PR has been verified |
Skipped merging 422: MWPW-159427: Milo Catalog: Ipad specific issues due to missing verified label. kindly make sure that the PR has been verified |
Skipped merging 422: MWPW-159427: Milo Catalog: Ipad specific issues due to missing verified label. kindly make sure that the PR has been verified |
Skipped merging 422: MWPW-159427: Milo Catalog: Ipad specific issues due to missing verified label. kindly make sure that the PR has been verified |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you clarify why merch-sidenav is still needed on cc w.r.t #412 (review) ?
Closing because the needed change will be added in the #412 |
On iOS version 15 and lower there is a different way of managing the vertical stacking context, which puts the modal below the merch card. Adding z-index on the merch-sidenav resolves this problem.
Related Milo PR: adobecom/milo#2994
Resolves: MWPW-159427
Test URLs:
For PSI check:
https://mwpw-159427-ipad-issues--milo--mirafedas.hlx.live/?martech=off&georouting=off