MWPW-159427: Milo Catalog: Ipad specific issues #2994
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mirafedas
requested review from
Axelcureno,
rahulgupta999,
3ch023,
rohitsahu,
bozojovicic and
seanchoi-dev
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## stage #2994 +/- ##
=======================================
Coverage 96.43% 96.43%
=======================================
Files 245 245
Lines 55727 55728 +1
=======================================
+ Hits 53740 53743 +3
+ Misses 1987 1985 -2 ☔ View full report in Codecov by Sentry. |
|
npeltier
approved these changes
Oct 2, 2024
|
This PR has not been updated recently and will be closed in 7 days if no action is taken. Please ensure all checks are passing, https://github.com/orgs/adobecom/discussions/997 provides instructions. If the PR is ready to be merged, please mark it with the "Ready for Stage" label. |
3ch023
approved these changes
Oct 17, 2024
|
@mirafedas - can we get this tested? thanks! |
sukamat
approved these changes
Oct 18, 2024
Axelcureno
approved these changes
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On iOS version 15 and lower there is a different way of managing the vertical stacking context, which puts the modal below the merch card. Adding z-index on the merch-sidenav resolves this problem.
Related CC PR: adobecom/cc#422
Resolves: MWPW-159427
Test URLs:
For PSI check:
https://mwpw-159427-ipad-issues--milo--mirafedas.hlx.live/?martech=off&georouting=off