Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MWPW-167030-follow up for milo refactoring of federals #63

Open
wants to merge 2 commits into
base: stage
Choose a base branch
from
+15 −9
Open

MWPW-167030-follow up for milo refactoring of federals #63

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0d5d02a
MWPW-167030-follow up for milo refactoring of federals
Feb 7, 2025
b03b2f7
Merge branch 'stage' into MWPW-167030
SonjaPopovic Feb 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions eds/blocks/partners-navigation/features/breadcrumbs/breadcrumbs.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,7 @@
// MWPW-159021
/* eslint-disable */
import { getMetadata, getConfig } from '../../../../utils/utils.js';
import { getMetadata, getConfig, getFederatedUrl } from '../../../../utils/utils.js';
import { toFragment, lanaLog } from '../../utilities/utilities.js';
import { getFederatedUrl } from '../../../../utils/federated.js';

const metadata = {
seo: 'breadcrumbs-seo',
Expand Down
4 changes: 2 additions & 2 deletions eds/blocks/partners-navigation/features/profile/dropdown.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@ import { getLibs } from '../../../../scripts/utils.js';

const miloLibs = getLibs();
const { replaceKeyArray } = await import(`${miloLibs}/features/placeholders.js`);
const { getConfig } = await import(`${miloLibs}/utils/utils.js`);
const { getFedsPlaceholderConfig } = await import(`${miloLibs}/utils/federated.js`);

const { getConfig, getFedsPlaceholderConfig } = await import(`${miloLibs}/utils/utils.js`);

const getLanguage = (ietfLocale) => {
if (!ietfLocale.length) return 'en';
Expand Down
2 changes: 1 addition & 1 deletion eds/blocks/partners-navigation/features/search/gnav-search.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ import {generateRequestForSearchAPI} from "../../../utils/utils.js";

const miloLibs = getLibs();
const { replaceKeyArray } = await import(`${miloLibs}/features/placeholders.js`);
const { getConfig } = await import(`${miloLibs}/utils/utils.js`);
const { getConfig, getFedsPlaceholderConfig } = await import(`${miloLibs}/utils/utils.js`);
const { debounce } = await import(`${miloLibs}/utils/action.js`);
const { getFedsPlaceholderConfig } = await import (`${miloLibs}/utils/federated.js`);

Expand Down
3 changes: 1 addition & 2 deletions eds/blocks/partners-navigation/partners-navigation.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,13 +48,12 @@ const {
loadIms,
decorateLinks,
loadScript,
getFedsPlaceholderConfig,
getGnavSource,
} = await import(`${miloLibs}/utils/utils.js`);
const { replaceKey, replaceKeyArray } = await import(`${miloLibs}/features/placeholders.js`);
// End

const { getFedsPlaceholderConfig } = await import(`${miloLibs}/utils/federated.js`);

const SIGNIN_CONTEXT = getConfig()?.signInContext;

function getHelpChildren() {
Expand Down
12 changes: 10 additions & 2 deletions eds/blocks/partners-navigation/utilities/utilities.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,17 @@ import { getLibs } from '../../../scripts/utils.js';

const miloLibs = getLibs();
const {
getConfig, getMetadata, loadStyle, loadLana, decorateLinks, localizeLink,
getConfig,
getMetadata,
loadStyle,
loadLana,
decorateLinks,
localizeLink,
getFederatedContentRoot,
getFederatedUrl,
getFedsPlaceholderConfig,
} = await import(`${miloLibs}/utils/utils.js`);
const { getFederatedContentRoot, getFederatedUrl, getFedsPlaceholderConfig } = await import(`${miloLibs}/utils/federated.js`);

const { processTrackingLabels } = await import(`${miloLibs}/martech/attributes.js`);
const { replaceText } = await import(`${miloLibs}/features/placeholders.js`);
// End
Expand Down
Loading