MWPW-153237: Test content for CCD validation #3040
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
There was a problem hiding this comment.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
There was a problem hiding this comment.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
There was a problem hiding this comment.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## stage #3040 +/- ##
=======================================
Coverage 96.43% 96.43%
=======================================
Files 245 245
Lines 55727 55727
=======================================
+ Hits 53740 53743 +3
+ Misses 1987 1984 -3 ☔ View full report in Codecov by Sentry. |
|
libs/features/mas/docs/styles.css
Outdated
| #log { | ||
| #log, | ||
| #log2, | ||
| #log3 { |
There was a problem hiding this comment.
this section is probably not part of your PR but that's okay, in the ccd branch for the rest of the docs it is needed.
There was a problem hiding this comment.
ho, true. copy paste from ccd state..
| <h5>Percentage</h5> | ||
| <h5>Two icons & pricing</h5> | ||
| <h5>See Terms link</h5> | ||
| <merch-card><aem-fragment fragment="0ef2a804-e788-4959-abb8-b4d96a18b0ef"></aem-fragment></merch-card> |
There was a problem hiding this comment.
nit: it would be good to add title="Actual Product Title". It would help whom reads the MD file or updates it.
There was a problem hiding this comment.
some of cards have no title though (and some have the same title)
I was just using the copy markup function of studio
There was a problem hiding this comment.
It doesn't need to be matching with the exact title.
It is more descriptive, like cc, photoshop, illustrator.
I think as a best practice we should adopt it, maybe I'm wrong.
| @@ -97,8 +99,7 @@ build({ | |||
| }); | |||
|
|
|||
| mods.forEach((mod) => { | |||
| if (mod === 'lit.js') return; | |||
| if (mod === 'polyfills') return; | |||
| if (mod === 'lit.js' || mod === 'polyfills' || mod === 'themes') return; | |||
There was a problem hiding this comment.
suggestion: if (['lit.js', 'polyfills', 'themes']).indexOf(mod) > -1 return;
There was a problem hiding this comment.
ah right, i remember i promised
will change to ['lit.js', 'polyfills', 'themes'].includes(mod), good?
|
Reminder to set the |
3ch023
added
run-nala
Add a gallery page with CCD card variations.
Cards are pulled from Odin. At the moment you need VPN to access Odin instance.
Includes Dark and Light mode.
Known Missing Items (due to feature incomplete of Studio/Cards):
Resolves: https://jira.corp.adobe.com/browse/MWPW-153237
Access the gallery at https://ccd--milo--adobecom.hlx.page/libs/features/mas/docs/ccd.html?theme=dark
CCD branch is required due to dependencies on other PRs.
Test URLs: