Improve RCP communication by sending out reminders #3070
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## stage #3070 +/- ##
==========================================
+ Coverage 96.40% 96.43% +0.03%
==========================================
Files 243 245 +2
Lines 55415 55727 +312
==========================================
+ Hits 53425 53743 +318
+ Misses 1990 1984 -6 ☔ View full report in Codecov by Sentry. |
mokimo
requested review from
robert-bogos,
overmyheadandbody and
narcis-radu
and removed request for
robert-bogos
robert-bogos
approved these changes
Oct 22, 2024
overmyheadandbody
approved these changes
Oct 22, 2024
JasonHowellSlavin
approved these changes
Oct 22, 2024
|
This pull request is not passing all required checks. Please see this discussion for information on how to get all checks passing. Inconsistent checks can be manually retried. If a test absolutely can not pass for a good reason, please add a comment with an explanation to the PR. |
|
Reminder to set the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Sends a reminder 10 and 4 days before an RCP to milo dev.
Reminder RCP starts in 4 days from Fri, 25 Oct 2024 07:00:00 GMT to Sun, 27 Oct 2024 00:00:00 GMT. Merges to stage will be disabled beginning Wed, 23 Oct 2024 07:00:00 GMT.My assumption: this can never trigger twice since this action runs once every 24h and we check if we are within a 24h timeframe, meaning we don't need to store any infos wether we already sent a message or not.
Resolves: MWPW-157289
Test URLs: