Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MWPW-161101 load sidekick button css faster if already open #3095

Merged
merged 5 commits into from
Nov 6, 2024

Conversation

vhargrave
Copy link
Contributor

@vhargrave vhargrave commented Oct 28, 2024

On certain pages, where it takes a while for all the content to load (such as MEP content), the sidekick's Publish and Tools buttons switch position. This is because Milo loads some css after page load, which switches the position of the publish button -

.
This PR fixes that issue.
To test just have the sidekick open on the linked test page.

Resolves: MWPW-161101

Test URLs:

Copy link
Contributor

aem-code-sync bot commented Oct 28, 2024

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

Copy link

codecov bot commented Oct 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.35%. Comparing base (8f0adc1) to head (c98ac68).
Report is 19 commits behind head on stage.

Additional details and impacted files
@@           Coverage Diff           @@
##            stage    #3095   +/-   ##
=======================================
  Coverage   96.34%   96.35%           
=======================================
  Files         245      245           
  Lines       56316    56318    +2     
=======================================
+ Hits        54256    54263    +7     
+ Misses       2060     2055    -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aem-code-sync aem-code-sync bot temporarily deployed to vhargrave/MWPW-161101-sidekick-buttons October 28, 2024 14:54 Inactive
@aem-code-sync aem-code-sync bot temporarily deployed to vhargrave/MWPW-161101-sidekick-buttons October 28, 2024 14:59 Inactive
Copy link
Contributor

This pull request is not passing all required checks. Please see this discussion for information on how to get all checks passing. Inconsistent checks can be manually retried. If a test absolutely can not pass for a good reason, please add a comment with an explanation to the PR.

@spadmasa spadmasa self-assigned this Oct 29, 2024
@spadmasa spadmasa added verified PR has been E2E tested by a reviewer Ready for Stage labels Oct 29, 2024
@milo-pr-merge
Copy link
Contributor

milo-pr-merge bot commented Oct 30, 2024

Skipped merging 3095: MWPW-161101 load sidekick button css faster if already open due to failing checks

@mokimo
Copy link
Contributor

mokimo commented Oct 31, 2024

@vhargrave mind adding a milo based link for the PSI check, so that the automation can properly merge this?

Copy link
Contributor

aem-code-sync bot commented Oct 31, 2024

Page Scores Audits Google
📱 / PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
🖥️ / PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@milo-pr-merge
Copy link
Contributor

milo-pr-merge bot commented Nov 4, 2024

Skipped 3095: "MWPW-161101 load sidekick button css faster if already open" due to file "libs/utils/utils.js" overlap. Merging will be attempted in the next batch

@milo-pr-merge milo-pr-merge bot merged commit 8be7f3c into stage Nov 6, 2024
14 checks passed
@milo-pr-merge milo-pr-merge bot deleted the vhargrave/MWPW-161101-sidekick-buttons branch November 6, 2024 09:17
@milo-pr-merge milo-pr-merge bot mentioned this pull request Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready for Stage verified PR has been E2E tested by a reviewer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants