-
Notifications
You must be signed in to change notification settings - Fork 181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MWPW-161101 load sidekick button css faster if already open #3095
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## stage #3095 +/- ##
=======================================
Coverage 96.34% 96.35%
=======================================
Files 245 245
Lines 56316 56318 +2
=======================================
+ Hits 54256 54263 +7
+ Misses 2060 2055 -5 ☔ View full report in Codecov by Sentry. |
This pull request is not passing all required checks. Please see this discussion for information on how to get all checks passing. Inconsistent checks can be manually retried. If a test absolutely can not pass for a good reason, please add a comment with an explanation to the PR. |
Skipped merging 3095: MWPW-161101 load sidekick button css faster if already open due to failing checks |
# Conflicts: # libs/utils/utils.js
@vhargrave mind adding a milo based link for the PSI check, so that the automation can properly merge this? |
Skipped 3095: "MWPW-161101 load sidekick button css faster if already open" due to file "libs/utils/utils.js" overlap. Merging will be attempted in the next batch |
On certain pages, where it takes a while for all the content to load (such as MEP content), the sidekick's Publish and Tools buttons switch position. This is because Milo loads some css after page load, which switches the position of the publish button -
milo/libs/utils/sidekick-decorate.js
Line 32 in ff054af
This PR fixes that issue.
To test just have the sidekick open on the linked test page.
Resolves: MWPW-161101
Test URLs:
Before: https://main--cc--adobecom.hlx.live/products/photoshop-lightroom
After: https://main--cc--adobecom.hlx.live/products/photoshop-lightroom?milolibs=vhargrave-MWPW-161101-sidekick-buttons
Before: https://main--milo--adobecom.hlx.live/
After: https://vhargrave-MWPW-161101-sidekick-buttons--milo--adobecom.hlx.live/