Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MWPW-161101 load sidekick button css faster if already open #3095

Merged
merged 5 commits into from
Nov 6, 2024
Merged

MWPW-161101 load sidekick button css faster if already open #3095

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
bdcd4d0
MWPW-161101 load sidekick button css faster if already open
vhargrave Oct 28, 2024
c1b1eec
MWPW-161101 load sk styles even earlier
vhargrave Oct 28, 2024
c012cd7
MWPW-161101 make code simpler
vhargrave Oct 28, 2024
98368da
MWPW-161101 move code to post lcp
vhargrave Oct 29, 2024
c98ac68
Merge branch 'stage' into vhargrave/MWPW-161101-sidekick-buttons
vhargrave Oct 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions libs/utils/sidekick-decorate.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,11 @@ import userCanPublishPage from '../tools/utils/publish.js';
const PUBLISH_BTN = '.publish.plugin button';
const PROFILE = '.profile-email';
const CONFIRM_MESSAGE = 'Are you sure? This will publish to production.';
let stylePublishCalled = false;

export default function stylePublish(sk) {
if (stylePublishCalled) return;
stylePublishCalled = true;
const setupPublishBtn = async (page, btn) => {
const { canPublish, message } = await userCanPublishPage(page, false);
if (canPublish) {
Expand Down
2 changes: 2 additions & 0 deletions libs/utils/utils.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1057,6 +1057,8 @@ async function checkForPageMods() {

async function loadPostLCP(config) {
await decoratePlaceholders(document.body.querySelector('header'), config);
const sk = document.querySelector('helix-sidekick');
if (sk) import('./sidekick-decorate.js').then((mod) => { mod.default(sk); });
if (config.mep?.targetEnabled === 'postlcp') {
/* c8 ignore next 2 */
const { init } = await import('../features/personalization/personalization.js');
Expand Down
Loading