Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MWPW-140397] Updated FEDS checks to work on GHA (FEDS-run) #234

Merged
merged 4 commits into from
Jan 11, 2024

Conversation

chadsunvice
Copy link
Contributor

No description provided.

@chadsunvice chadsunvice added the run-nala-feds Run Nala Test Automation against FEDS tests only label Dec 18, 2023
@skumar09
Copy link
Contributor

@chadsunvice : A few Jarvis tests are failing. Can you please take a look?

@JackySun9
Copy link
Contributor

Yes, please fix the test failures

@chadsunvice
Copy link
Contributor Author

@chadsunvice : A few Jarvis tests are failing. Can you please take a look?

I'm looking into it! I saw, the same story with Jarvis issues on US side.

@chadsunvice
Copy link
Contributor Author

@narcis-radu found a workaround to have Jarvis show on GHA: adding env=prod browser param for Jarvis checks.

Thus, we are forcing the HXL production ecosystem. Excerpt of logic affecting Jarvis not showing while running on hlx.live (STAGE environment):

  if (query) return { ...ENVS[query], consumer: conf[query] };
  if (host.includes('localhost')) return { ...ENVS.local, consumer: conf.local };
  /* c8 ignore start */
  if (host.includes('hlx.page')
    || host.includes('hlx.live')
    || host.includes('stage.adobe')
    || host.includes('corp.adobe')) {
    return { ...ENVS.stage, consumer: conf.stage };
  }
  return { ...ENVS.prod, consumer: conf.prod };

A small issue remains that IMS_EMAIL & IMS_PASS are not present. @skumar09 / @amauch-adobe Please approve so we can merge. If possible look into why the IMS_EMAIL & IMS_PASS are unavailable on this and how can we prevent in the future. For now, test.skiped the affected UserProfile check.

@chadsunvice chadsunvice merged commit 0ae64ab into adobecom:main Jan 11, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
run-nala-feds Run Nala Test Automation against FEDS tests only
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants