Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MWPW-140397] Updated FEDS checks to work on GHA (FEDS-run) #234

Merged
merged 4 commits into from
Jan 11, 2024
Merged

[MWPW-140397] Updated FEDS checks to work on GHA (FEDS-run) #234

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1430157
[MWPW-140397] Updated FEDS checks to work on GHA (FEDS-run)
chadsunvice Dec 18, 2023
764c679
[MWPW-140397] Force Milo production to show Jarvis without VPN
chadsunvice Jan 11, 2024
c3f3918
[MWPW-140397] Skip UserProfile checks until IMS creddentials issue is…
chadsunvice Jan 11, 2024
7d4863c
Merge branch 'main' of github.com:adobecom/nala into MWPW-140397_fix_…
chadsunvice Jan 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions features/feds/jarvis.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ module.exports = {
path: [
'/libs/feds/drafts/qa/jarvis/feds-jarvis-default',
],
browserParams: '?customPrivacyLocation=de&georouting=off',
browserParams: '?skipConsent=true&env=prod&georouting=off',
envs: '@milo_live',
tags: '@milo @feds @jarvis @smoke @regression',
},
Expand All @@ -15,7 +15,7 @@ module.exports = {
path: [
'/libs/feds/drafts/qa/jarvis/feds-jarvis-desktop',
],
browserParams: '?customPrivacyLocation=de&georouting=off',
browserParams: '?skipConsent=true&env=prod&georouting=off',
envs: '@milo_live',
tags: '@milo @feds @jarvis @smoke @regression',
},
Expand All @@ -24,7 +24,7 @@ module.exports = {
path: [
'/libs/feds/drafts/qa/jarvis/feds-jarvis-disabled',
],
browserParams: '?customPrivacyLocation=de&georouting=off',
browserParams: '?skipConsent=true&env=prod&georouting=off',
envs: '@milo_live',
tags: '@milo @feds @jarvis @smoke @regression',
},
Expand All @@ -33,7 +33,7 @@ module.exports = {
path: [
'/libs/feds/drafts/qa/jarvis/feds-jarvis-mobile',
],
browserParams: '?customPrivacyLocation=de&georouting=off',
browserParams: '?skipConsent=true&env=prod&georouting=off',
envs: '@milo_live',
tags: '@milo @feds @jarvis @smoke @regression',
},
Expand Down
6 changes: 4 additions & 2 deletions features/feds/placeholders.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,8 @@ module.exports = {
path: [
'/placeholders.json',
'/de/placeholders.json',
'/fr/placeholders.json',
// !Note: FR locale placeholders currently broken (known issue).
// '/fr/placeholders.json',
'/jp/placeholders.json',
'/uk/placeholders.json',
],
Expand All @@ -18,7 +19,8 @@ module.exports = {
path: [
'/placeholders.json',
'/de/placeholders.json',
'/fr/placeholders.json',
// !Note: FR locale placeholders currently broken (known issue).
// '/fr/placeholders.json',
'/jp/placeholders.json',
'/uk/placeholders.json',
],
Expand Down
27 changes: 0 additions & 27 deletions tests/feds/jarvis.desktop.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,13 +4,11 @@
import { expect, test } from '@playwright/test';
import { features } from '../../features/feds/jarvis.spec.js';
import FedsJarvis from '../../selectors/feds/feds.jarvis.page.js';
import FedsConsent from '../../selectors/feds/feds.consent.page.js';

test.describe('Jarvis Component test suite', () => {
// FEDS Jarvis Default Checks:
test(`${features[0].name}, ${features[0].tags}`, async ({ page, baseURL }) => {
const Jarvis = new FedsJarvis(page);
const Consent = new FedsConsent(page);
console.info(`[FEDSInfo] Checking page: ${baseURL}${features[0].path}`);

await test.step('Navigate to FEDS Jarvis Default page', async () => {
Expand All @@ -19,13 +17,6 @@ test.describe('Jarvis Component test suite', () => {
await expect(page).toHaveURL(`${baseURL}${features[0].path}${features[0].browserParams}`);
});

await test.step('Accept OneTrust consent bar', async () => {
// Wait for the OneTrust consent bar to appear:
await Consent.oneTrustContainer.waitFor({ state: 'visible', timeout: 20000 });
// Accept the OneTrust consent banner:
await Consent.acceptOneTrustConsentBar();
});

await test.step('Check Jarvis component functionality', async () => {
// Open Jarvis chat assistant (via Jarvis button):
await Jarvis.openJarvisFromCta();
Expand All @@ -43,7 +34,6 @@ test.describe('Jarvis Component test suite', () => {
// FEDS Jarvis Desktop Checks:
test(`${features[1].name}, ${features[1].tags}`, async ({ page, baseURL }) => {
const Jarvis = new FedsJarvis(page);
const Consent = new FedsConsent(page);
console.info(`[FEDSInfo] Checking page: ${baseURL}${features[1].path}`);

await test.step('Navigate to FEDS Jarvis Desktop page', async () => {
Expand All @@ -52,13 +42,6 @@ test.describe('Jarvis Component test suite', () => {
await expect(page).toHaveURL(`${baseURL}${features[1].path}${features[1].browserParams}`);
});

await test.step('Accept OneTrust consent bar', async () => {
// Wait for the OneTrust consent bar to appear:
await Consent.oneTrustContainer.waitFor({ state: 'visible', timeout: 20000 });
// Accept the OneTrust consent banner:
await Consent.acceptOneTrustConsentBar();
});

await test.step('Check Jarvis component functionality', async () => {
// Open Jarvis chat assistant (via Jarvis button):
await Jarvis.openJarvisFromCta();
Expand All @@ -76,7 +59,6 @@ test.describe('Jarvis Component test suite', () => {
// FEDS Jarvis Disabled Checks:
test(`${features[2].name}, ${features[2].tags}`, async ({ page, baseURL }) => {
const Jarvis = new FedsJarvis(page);
const Consent = new FedsConsent(page);
console.info(`[FEDSInfo] Checking page: ${baseURL}${features[2].path}`);

await test.step('Navigate to FEDS Jarvis Disabled page', async () => {
Expand All @@ -85,15 +67,6 @@ test.describe('Jarvis Component test suite', () => {
await expect(page).toHaveURL(`${baseURL}${features[2].path}${features[2].browserParams}`);
});

await test.step('Accept OneTrust consent bar', async () => {
// Wait for the OneTrust consent bar to appear:
await Consent.oneTrustContainer.waitFor({ state: 'visible', timeout: 20000 });
// Accept the OneTrust consent banner:
await Consent.acceptOneTrustConsentBar();
// Check consent persistence:
await Consent.assertOneTrustAcceptState();
});

await test.step('Check Jarvis component is not initialized', async () => {
// Check Jarvis component doesn't get initialized:
await Jarvis.jarvisButton.waitFor({ state: 'hidden', timeout: 15000 });
Expand Down
11 changes: 0 additions & 11 deletions tests/feds/jarvis.mobile.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
import { expect, test } from '@playwright/test';
import { features } from '../../features/feds/jarvis.spec.js';
import FedsJarvis from '../../selectors/feds/feds.jarvis.page.js';
import FedsConsent from '../../selectors/feds/feds.consent.page.js';

test.describe('Jarvis Component test suite', () => {
// Setup viewport to trigger mobile logic:
Expand All @@ -18,7 +17,6 @@ test.describe('Jarvis Component test suite', () => {
// FEDS Jarvis Mobile Checks:
test(`${features[3].name}, ${features[3].tags}`, async ({ page, baseURL }) => {
const Jarvis = new FedsJarvis(page);
const Consent = new FedsConsent(page);
console.info(`[FEDSInfo] Checking page: ${baseURL}${features[3].path}`);

await test.step('Navigate to FEDS Jarvis Default page', async () => {
Expand All @@ -27,15 +25,6 @@ test.describe('Jarvis Component test suite', () => {
await expect(page).toHaveURL(`${baseURL}${features[3].path}${features[3].browserParams}`);
});

await test.step('Accept OneTrust consent bar', async () => {
// Wait for the OneTrust consent bar to appear:
await Consent.oneTrustContainer.waitFor({ state: 'visible', timeout: 20000 });
// Accept the OneTrust consent banner:
await Consent.acceptOneTrustConsentBar();
// Check consent persistence:
await Consent.assertOneTrustAcceptState();
});

await test.step('Check Jarvis component is initialized', async () => {
// Wait for Jarvis component to appear:
await Jarvis.jarvisButton.waitFor({ state: 'visible', timeout: 15000 });
Expand Down
2 changes: 1 addition & 1 deletion tests/feds/userprofile.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ import FedsHeader from '../../selectors/feds/feds.header.page.js';

test.describe('User Profile Component test suite', () => {
// FEDS User Profile Checks:
test(`${features[0].name}, ${features[0].tags}`, async ({ page, baseURL }) => {
test.skip(`${features[0].name}, ${features[0].tags}`, async ({ page, baseURL }) => {
const Login = new FedsLogin(page);
const Header = new FedsHeader(page);
console.info(`[FEDSInfo] Checking page: ${baseURL}${features[0].path}`);
Expand Down
Loading