Skip to content

feat: estimate transaction size in the FFI crate #81

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

CiottiGiorgio
Copy link
Member

I thought this code is common enough we might want it in core.

I am still missing a way to do it in the rust crate. After I do that, the FFI crate should only re-expose what's in the core crate.

Also, I haven't taken the approach of actually signing it as it a slow operation. I decided to attach an invalid signature, encode, and get the size.

I've also seen a bunch of times just adding 75 to the encoding length without a signature. I am assuming 75 comes up from the field name, the encoding and the signature length.
What approach do we think is best?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant