Skip to content

feat(catalog): add LoadTableSchema interface#10

Merged
lxy-9602 merged 2 commits intoalibaba:mainfrom
dalingmeng:feature-load_table_schema
Dec 18, 2025
Merged

feat(catalog): add LoadTableSchema interface#10
lxy-9602 merged 2 commits intoalibaba:mainfrom
dalingmeng:feature-load_table_schema

Conversation

@dalingmeng
Copy link
Copy Markdown
Contributor

Purpose

Catalog add loadTableSchema interface.

Tests

file_system_catalog_test.cpp : TEST(FileSystemCatalogTest, TestValidateTableSchema);

API and Format

Documentation

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Dec 16, 2025

CLA assistant check
All committers have signed the CLA.

@lxy-9602 lxy-9602 requested a review from lucasfang December 16, 2025 08:40
@dalingmeng dalingmeng force-pushed the feature-load_table_schema branch 6 times, most recently from 642de87 to e90b3af Compare December 17, 2025 14:33
@lucasfang lucasfang requested a review from Copilot December 18, 2025 03:28
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds a LoadTableSchema interface to the Catalog API, allowing users to retrieve table schema metadata. It introduces a new public Schema class that wraps TableSchema and provides access to table metadata through a simplified interface.

Key changes:

  • Adds LoadTableSchema method to the Catalog interface that returns schema information for a specified table
  • Introduces a new public Schema class in include/paimon/schema/schema.h that provides accessors for table metadata
  • Adds GetArrowSchema() method to TableSchema to export schema to Arrow C Data Interface format

Reviewed changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 7 comments.

Show a summary per file
File Description
include/paimon/catalog/catalog.h Adds LoadTableSchema pure virtual method to Catalog interface
include/paimon/schema/schema.h Defines new public Schema class with metadata accessors
src/paimon/core/catalog/file_system_catalog.h Implements LoadTableSchema and exposes GetFileSystem/Warehouse methods
src/paimon/core/catalog/file_system_catalog.cpp Implements LoadTableSchema by delegating to Schema::MakeImpl
src/paimon/core/schema/schema.cpp Implements Schema class with delegation to internal TableSchema
src/paimon/core/schema/table_schema.h Declares GetArrowSchema method
src/paimon/core/schema/table_schema.cpp Implements GetArrowSchema using Arrow C Data Interface export
src/paimon/core/catalog/file_system_catalog_test.cpp Adds comprehensive test coverage for LoadTableSchema functionality
src/paimon/CMakeLists.txt Adds schema.cpp to build configuration

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@dalingmeng dalingmeng force-pushed the feature-load_table_schema branch 4 times, most recently from 72631ca to 5ff2fea Compare December 18, 2025 04:55
@dalingmeng dalingmeng force-pushed the feature-load_table_schema branch 3 times, most recently from 97e4de7 to f2678f9 Compare December 18, 2025 06:29
@dalingmeng dalingmeng force-pushed the feature-load_table_schema branch from f198e6a to 84794b5 Compare December 18, 2025 06:38
Copy link
Copy Markdown
Collaborator

@lxy-9602 lxy-9602 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@lxy-9602 lxy-9602 merged commit 1ecea8e into alibaba:main Dec 18, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants