Skip to content

fix: LoadTableSchema returns NotExist error instead of null when table does not exist#40

Merged
lxy-9602 merged 1 commit intoalibaba:mainfrom
lxy-9602:fix-loadschema-for-catalog
Jan 4, 2026
Merged

fix: LoadTableSchema returns NotExist error instead of null when table does not exist#40
lxy-9602 merged 1 commit intoalibaba:mainfrom
lxy-9602:fix-loadschema-for-catalog

Conversation

@lxy-9602
Copy link
Copy Markdown
Collaborator

@lxy-9602 lxy-9602 commented Jan 2, 2026

Purpose

Linked pr: #10

Previously, LoadTableSchema() in Catalogreturned nullopt when the requested table did not exist, which made error handling ambiguous.

This change ensures that a clear NotExist error is returned in such cases, aligning with Java implementation.

Tests

FileSystemCatalogTest.TestValidateTableSchema

API and Format

In catalog.h:

Result<std::shared_ptr<Schema>> LoadTableSchema(const Identifier& identifier) const;

@lucasfang
Copy link
Copy Markdown
Collaborator

+1

@lxy-9602 lxy-9602 merged commit 580b53a into alibaba:main Jan 4, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants