Ipo finder nested facets #3160
Merged
Ipo finder nested facets #3160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lauraghiorghisor-tw
force-pushed
the
ipo-finder-nested-facets
branch
2 times, most recently
from
b96484d to
4b8f519
Compare
minhngocd
force-pushed
the
ipo-finder-nested-facets
branch
from
4b8f519 to
39d0f37
Compare
lauraghiorghisor-tw
force-pushed
the
ipo-finder-nested-facets
branch
from
39d0f37 to
b60ce0f
Compare
ChrisBAshton
approved these changes
Feb 25, 2025
There was a problem hiding this comment.
I do wonder if we could make it clearer that the main_facet_value is the important bit for linking (otherwise my first instinct was "why do we have to define the sub_facet_key/name and the main_facet_label/value?"). But couldn't think of a way of rephrasing the description to make it clearer 🤔
minhngocd
force-pushed
the
ipo-finder-nested-facets
branch
from
b60ce0f to
f5a5577
Compare
Updated the description. Would that read better? |
minhngocd
pushed a commit
that referenced
this pull request
Feb 25, 2025
We have changed approach in the way we implemented nested facets. Nested facets are now sent as two separate facets independently with a cross reference link between them, therefore we no longer need to send sub-facets as part of the finder schema. #3160
Finder frontend and Government frontend view the nested facets as 2 separate facets. We make it easier by sending them as separate facets with a reference back to their main facet value. Main facet label is also required to populate the subfacet label in the format `Main facet label - Sub Facet Label` for when JS is disabled. The changes made in SP now make the use of `sub_facets` field obsolete, but the removal of that field will be done in a separate PR.
lauraghiorghisor-tw
force-pushed
the
ipo-finder-nested-facets
branch
from
f5a5577 to
af88dbe
Compare
minhngocd
pushed a commit
that referenced
this pull request
Feb 26, 2025
We have changed approach in the way we implemented nested facets. Nested facets are now sent as two separate facets independently with a cross reference link between them, therefore we no longer need to send sub-facets as part of the finder schema. #3160
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding some additional required fields for nested facets.
Trello