Remove sub_facets field from nested facets schema #3161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lauraghiorghisor-tw
force-pushed
the
ipo-finder-nested-facets
branch
2 times, most recently
from
b96484d to
4b8f519
Compare
minhngocd
force-pushed
the
ipo-finder-nested-facets
branch
from
4b8f519 to
39d0f37
Compare
lauraghiorghisor-tw
changed the title
lauraghiorghisor-tw
force-pushed
the
revert-ci-branch-change
branch
from
03a208b to
5ca38b7
Compare
lauraghiorghisor-tw
force-pushed
the
ipo-finder-nested-facets
branch
from
39d0f37 to
b60ce0f
Compare
lauraghiorghisor-tw
force-pushed
the
revert-ci-branch-change
branch
from
5ca38b7 to
9aaabcb
Compare
ChrisBAshton
approved these changes
Feb 25, 2025
There was a problem hiding this comment.
Would be a good idea to refer to #3160 in the commit message so that future devs don't have to dig through GitHub histories to figure out what this replaces 👍
minhngocd
force-pushed
the
ipo-finder-nested-facets
branch
from
b60ce0f to
f5a5577
Compare
minhngocd
force-pushed
the
revert-ci-branch-change
branch
from
9aaabcb to
5fd722a
Compare
Done 👍 |
lauraghiorghisor-tw
force-pushed
the
ipo-finder-nested-facets
branch
from
f5a5577 to
af88dbe
Compare
lauraghiorghisor-tw
force-pushed
the
revert-ci-branch-change
branch
from
5fd722a to
5b55dbc
Compare
We have changed approach in the way we implemented nested facets. Nested facets are now sent as two separate facets independently with a cross reference link between them, therefore we no longer need to send sub-facets as part of the finder schema. #3160
minhngocd
force-pushed
the
revert-ci-branch-change
branch
from
5b55dbc to
3cfa90d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We no longer send the
sub_facets.Trello