Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove sub_facets field from nested facets schema #3161

Merged
merged 1 commit into from
Feb 26, 2025
Merged

Remove sub_facets field from nested facets schema #3161

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 1 addition & 39 deletions content_schemas/dist/formats/finder/frontend/schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -403,7 +403,7 @@
"description": "Possible values to show for non-dynamic select facets. All values are shown regardless of the search.",
"type": "array",
"items": {
"$ref": "#/definitions/label_value_pair_with_sub_facets"
"$ref": "#/definitions/label_value_pair"
}
},
"closed_value": {
Expand Down Expand Up @@ -839,44 +839,6 @@
}
}
},
"label_value_pair_with_sub_facets": {
"description": "One of many possible values a user can select from",
"type": "object",
"required": [
"label",
"value"
],
"additionalProperties": false,
"properties": {
"default": {
"description": "The default option for a radio facet",
"type": "boolean"
},
"label": {
"description": "A human readable label",
"type": "string"
},
"main_facet_label": {
"description": "A label that refers to the main facet label of this facet if it is a sub facet. The label is used to generate sub facet labels on frontend apps.",
"type": "string"
},
"main_facet_value": {
"description": "A value that refers to the main facet value of this facet if it is a sub facet. The value is used to group sub facets into sub category groupings for navigational purposes.",
"type": "string"
},
"sub_facets": {
"description": "Possible values to show for non-dynamic select nested facets. All values are shown regardless of the search.",
"type": "array",
"items": {
"$ref": "#/definitions/label_value_pair"
}
},
"value": {
"description": "A value to use for form controls",
"type": "string"
}
}
},
"locale": {
"type": "string",
"enum": [
Expand Down
40 changes: 1 addition & 39 deletions content_schemas/dist/formats/finder/notification/schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -503,7 +503,7 @@
"description": "Possible values to show for non-dynamic select facets. All values are shown regardless of the search.",
"type": "array",
"items": {
"$ref": "#/definitions/label_value_pair_with_sub_facets"
"$ref": "#/definitions/label_value_pair"
}
},
"closed_value": {
Expand Down Expand Up @@ -952,44 +952,6 @@
}
}
},
"label_value_pair_with_sub_facets": {
"description": "One of many possible values a user can select from",
"type": "object",
"required": [
"label",
"value"
],
"additionalProperties": false,
"properties": {
"default": {
"description": "The default option for a radio facet",
"type": "boolean"
},
"label": {
"description": "A human readable label",
"type": "string"
},
"main_facet_label": {
"description": "A label that refers to the main facet label of this facet if it is a sub facet. The label is used to generate sub facet labels on frontend apps.",
"type": "string"
},
"main_facet_value": {
"description": "A value that refers to the main facet value of this facet if it is a sub facet. The value is used to group sub facets into sub category groupings for navigational purposes.",
"type": "string"
},
"sub_facets": {
"description": "Possible values to show for non-dynamic select nested facets. All values are shown regardless of the search.",
"type": "array",
"items": {
"$ref": "#/definitions/label_value_pair"
}
},
"value": {
"description": "A value to use for form controls",
"type": "string"
}
}
},
"locale": {
"type": "string",
"enum": [
Expand Down
40 changes: 1 addition & 39 deletions content_schemas/dist/formats/finder/publisher_v2/schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -291,7 +291,7 @@
"description": "Possible values to show for non-dynamic select facets. All values are shown regardless of the search.",
"type": "array",
"items": {
"$ref": "#/definitions/label_value_pair_with_sub_facets"
"$ref": "#/definitions/label_value_pair"
}
},
"closed_value": {
Expand Down Expand Up @@ -601,44 +601,6 @@
}
}
},
"label_value_pair_with_sub_facets": {
"description": "One of many possible values a user can select from",
"type": "object",
"required": [
"label",
"value"
],
"additionalProperties": false,
"properties": {
"default": {
"description": "The default option for a radio facet",
"type": "boolean"
},
"label": {
"description": "A human readable label",
"type": "string"
},
"main_facet_label": {
"description": "A label that refers to the main facet label of this facet if it is a sub facet. The label is used to generate sub facet labels on frontend apps.",
"type": "string"
},
"main_facet_value": {
"description": "A value that refers to the main facet value of this facet if it is a sub facet. The value is used to group sub facets into sub category groupings for navigational purposes.",
"type": "string"
},
"sub_facets": {
"description": "Possible values to show for non-dynamic select nested facets. All values are shown regardless of the search.",
"type": "array",
"items": {
"$ref": "#/definitions/label_value_pair"
}
},
"value": {
"description": "A value to use for form controls",
"type": "string"
}
}
},
"locale": {
"type": "string",
"enum": [
Expand Down
2 changes: 1 addition & 1 deletion content_schemas/formats/shared/definitions/finder.jsonnet
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -223,7 +223,7 @@
description: "Possible values to show for non-dynamic select facets. All values are shown regardless of the search.",
type: "array",
items: {
"$ref": "#/definitions/label_value_pair_with_sub_facets",
"$ref": "#/definitions/label_value_pair",
},
},
option_lookup: {
Expand Down
40 changes: 0 additions & 40 deletions content_schemas/formats/shared/definitions/label_value_pair_with_sub_facets.jsonnet
View file
Open in desktop

This file was deleted.

Loading