add Lattice Nexus vendor platform (using nextpnr-nexus and prjoxide) #759

slagernate · 2023-03-02T04:26:02Z

sorry, github newb. Won't do that again. Tested again with blinking all LEDs. Output:

python3 -m amaranth_boards.lifcl_evn
init..
IDCODE: 0x110f1043 (LIFCL-40)
NX Status Register: 0x0000150100400100
reset..
NX Status Register: 0x0000150100400e50
programming..
NX Status Register: 0x0000150100400100
Bye.

Notes:
--Removed mention of ECP5 in lattice_nexus.py
--Removed OSC

codecov · 2023-03-02T04:28:31Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.44%. Comparing base (b36e7e0) to head (51f5769).
Report is 9 commits behind head on main.

❗ Current head 51f5769 differs from pull request most recent head 8ccc083. Consider uploading reports for the commit 8ccc083 to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #759      +/-   ##
==========================================
- Coverage   89.94%   89.44%   -0.50%     
==========================================
  Files          44       43       -1     
  Lines       10647     9066    -1581     
  Branches     2595     2150     -445     
==========================================
- Hits         9576     8109    -1467     
+ Misses        882      781     -101     
+ Partials      189      176      -13

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

richardeoin · 2023-03-06T20:54:45Z

FWIW I've been using amaranth with radiant and a nexus LFD2NX-40 part, and intend to contribute a platform definition when I'm happy with it (likely in a few weeks). I'll check back to see what the status of this is then.

whitequark · 2023-03-07T05:06:30Z

I'm currently waiting on a LIFCL-EVN board so that I can do regression testing for this platform.

whitequark · 2023-05-12T15:02:43Z

Good news: I've received the devboard I can test this on! I'll merge it soon.

slagernate · 2023-05-16T18:48:00Z

@richardeoin how's your platform file looking?

richardeoin · 2023-05-17T21:38:15Z

@slagernate Here's the platform file I'm using with LFD2NX-40 + Radiant. I tweaked my formatting to make it somewhat more diff-able against yours.

Some differences

Adds a two-stage FF sync into i_GSR_N of GSR (is this necessary?)
Adds an OSCA if self.default_clk == "OSCA"
Specifies p_GSR="DISABLED" on IDDRX1 and IDDRX2 instances 😱 Probably don't do this
Less tortured templating syntax for generating the .pdc constraints

I initially tested without triggering a GSR after startup and observed some very unexpected behaviour from IDDR ODDR and BB primitives. After that I assume that triggering a GSR after startup is mandatory for correct operation on these parts. Skip my workaround of putting p_GSR="DISABLED" on IDDRX instances.

I've only tested with radiant and didn't use radiant's programmer tool at all.

amaranth/vendor/lattice_nexus.py

…nx platform file (not tested)

slagernate · 2023-05-28T05:43:30Z

See latest suggested commit where I've pulled in your platform file @richardeoin . This works for the Radiant and Oxide / NextPnr tool chain with the LIFCL-40-EVN (Crosslink-NX Eval Board).

amaranth/vendor/lattice_nexus.py

whitequark · 2023-06-27T12:47:16Z

The current plan is to go through the backlog of PRs after amaranth-lang/rfcs#2 gets merged.

richardeoin · 2024-01-27T22:01:44Z

There have been subsequent improvements to amaranth/vendor and this PR needs at a minimum to be updated to include those.

@slagernate are you willing to maintain this PR (no is an ok answer!! :) )? It would be great to see it merged, and if you can't I'd happy to do the work (and have my own LFD2NX-40 test hardware).

slagernate · 2024-01-30T08:02:41Z

@richardeoin more than willing to update the PR, just need to find some spare time (perhaps in the next week). Have been using Amaranth + Radiant quite a bit (the PCLKDIV primitive in Oxide is missing :| ). But also totally happy if you'd like to take the reins!

whitequark · 2024-01-30T12:58:01Z

This PR has languished for a bit too long--I'll add it to the 0.5 milestone to make sure it's merged before then.

slagernate · 2024-01-30T21:53:14Z

Should be compatible with RFC#18 now.

amaranth/vendor/_lattice_nexus.py

slagernate · 2024-03-12T22:09:50Z

Updated to use tcl_quote instead of tcl_escape.

amaranth/vendor/_lattice_nexus.py

whitequark · 2024-04-09T19:34:39Z

amaranth/vendor/_lattice_nexus.py

+            {% for net_signal, port_signal, frequency in platform.iter_clock_constraints() -%}
+            {#
+                {% if port_signal is not none -%}
+                    set_frequency "{{port_signal.name}}" {{frequency/1000000}};


Why does this have different syntax than the below? Is one of the commands broken?

set_frequency is not supported by nextpnr-nexus, so this has been removed in 8ccc083 (tbh I don't remember why the syntax differs, or where set_frequency came from).

I don't think that's legitimate--how would nextpnr know the timing target for your design? Or, equally, how do you know that your design will function with the clock you give it?

I tried looking into how to pass timing info to nextpnr and according to nextpnr/docs/nexus.md:

"Timing constraints are currently ignored, but should be expected to be supported soon."

A grep of set_frequency in nextpnr only surfaces results for ice40.

A workaround I've been using is os.environ["AMARANTH_nextpnr_opts"] = "--freq 66.67 -r -v"

@gatecat Do you think that's something we can have shipped in nextpnr soonish? It's fairly hard to convince myself to add support for the --freq workaround.

The create_clock command should work in a PDC file - it seems like the docs are just out of date, I'll fix them tomorrow.

Clocks should also be automatically propagated through PLLs when that is used.

Just to confirm, that works with Radiant as well, right?

amaranth/vendor/_lattice_nexus.py

…de. NFC

wanda-phi · 2024-04-11T10:52:11Z

amaranth/vendor/_lattice_nexus.py

+            return True
+        return False
+
+    def _get_xdr_buffer(self, m, pin, *, i_invert=False, o_invert=False):


Note that all of this stuff will need to be completely redone as per RFC 55 — see #1295 for an example of the changes required.

whitequark · 2024-04-19T16:02:08Z

Superseded by #1342, since recent internal refactoring made this PR unmergeable. However, #1342 is based on this work--thank you!

add Lattice Nexus vendor platform (using nextpnr-nexus and prjoxide)

764c501

richardeoin reviewed May 17, 2023

View reviewed changes

amaranth/vendor/lattice_nexus.py Outdated Show resolved Hide resolved

amaranth/vendor/lattice_nexus.py Outdated Show resolved Hide resolved

slagernate and others added 2 commits May 27, 2023 20:58

Merge branch 'amaranth-lang:main' into main

3debc64

test crosslink-nx devices using Radiant toolchain. Merge with certus-…

2beca63

…nx platform file (not tested)

whitequark reviewed Jun 7, 2023

View reviewed changes

amaranth/vendor/lattice_nexus.py Outdated Show resolved Hide resolved

slagernate commented Jun 7, 2023

View reviewed changes

amaranth/vendor/lattice_nexus.py Outdated Show resolved Hide resolved

amaranth/vendor/lattice_nexus.py Outdated Show resolved Hide resolved

amaranth/vendor/lattice_nexus.py Outdated Show resolved Hide resolved

conform IO_TYPEs to Nexus sysIO (FPGA-TN-02067-1-8)

2669265

slagernate added 3 commits September 25, 2023 16:48

Merge branch 'amaranth-lang:main' into main

6e00dc2

fix jinja2 generation of lattice nexus constraints for oxide toolchain

7dcfafb

Merge branch 'amaranth-lang:main' into main

46c076e

whitequark added this to the 0.5 milestone Jan 30, 2024

slagernate added 2 commits January 30, 2024 12:11

Merge branch 'amaranth-lang:main' into main

92fdf9b

update Lattice Nexus vendor platform to comply with RFC#18

750a0ab

whitequark reviewed Jan 30, 2024

View reviewed changes

amaranth/vendor/_lattice_nexus.py Outdated Show resolved Hide resolved

remove stray space (line 468) and unused imports in _lattice_nexus.py

3e99ee4

slagernate temporarily deployed to publish March 12, 2024 22:07 — with GitHub Actions Inactive

replace tcl_escape with tcl_quote in Lattice Nexus vendor platform

51f5769

slagernate force-pushed the main branch from 2102cbc to 51f5769 Compare March 12, 2024 22:08

slagernate temporarily deployed to publish March 12, 2024 22:13 — with GitHub Actions Inactive

whitequark mentioned this pull request Mar 22, 2024

Roadmap to Amaranth 0.5 #1225

Closed

77 tasks

whitequark reviewed Apr 9, 2024

View reviewed changes

amaranth/vendor/_lattice_nexus.py Outdated Show resolved Hide resolved

whitequark reviewed Apr 9, 2024

View reviewed changes

amaranth/vendor/_lattice_nexus.py Outdated Show resolved Hide resolved

whitequark reviewed Apr 9, 2024

View reviewed changes

amaranth/vendor/_lattice_nexus.py Outdated Show resolved Hide resolved

whitequark reviewed Apr 9, 2024

View reviewed changes

amaranth/vendor/_lattice_nexus.py Outdated Show resolved Hide resolved

slagernate added 2 commits April 11, 2024 03:39

Merge branch 'amaranth-lang:main' into main

1cc36c2

vendor: remove unused/untested/unintelligible _lattice_nexus build co…

8ccc083

…de. NFC

slagernate temporarily deployed to publish April 11, 2024 10:47 — with GitHub Actions Inactive

wanda-phi reviewed Apr 11, 2024

View reviewed changes

wanda-phi mentioned this pull request Apr 19, 2024

vendor._lattice: add Nexus support. #1342

Merged

whitequark closed this Apr 19, 2024

polymerizedsage mentioned this pull request Apr 19, 2024

vendor._lattice: Add clock constraints to oxide .pdc template. #1343

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add Lattice Nexus vendor platform (using nextpnr-nexus and prjoxide) #759

add Lattice Nexus vendor platform (using nextpnr-nexus and prjoxide) #759

slagernate commented Mar 2, 2023

codecov bot commented Mar 2, 2023 •

edited

Loading

richardeoin commented Mar 6, 2023

whitequark commented Mar 7, 2023

whitequark commented May 12, 2023

slagernate commented May 16, 2023

richardeoin commented May 17, 2023

slagernate commented May 28, 2023 •

edited

Loading

whitequark commented Jun 27, 2023

richardeoin commented Jan 27, 2024

slagernate commented Jan 30, 2024

whitequark commented Jan 30, 2024

slagernate commented Jan 30, 2024

slagernate commented Mar 12, 2024

whitequark Apr 9, 2024

slagernate Apr 11, 2024

whitequark Apr 11, 2024

slagernate Apr 11, 2024 •

edited

Loading

whitequark Apr 11, 2024

gatecat Apr 11, 2024

whitequark Apr 11, 2024

wanda-phi Apr 11, 2024

whitequark commented Apr 19, 2024

add Lattice Nexus vendor platform (using nextpnr-nexus and prjoxide) #759

add Lattice Nexus vendor platform (using nextpnr-nexus and prjoxide) #759

Conversation

slagernate commented Mar 2, 2023

codecov bot commented Mar 2, 2023 • edited Loading

Codecov Report

richardeoin commented Mar 6, 2023

whitequark commented Mar 7, 2023

whitequark commented May 12, 2023

slagernate commented May 16, 2023

richardeoin commented May 17, 2023

slagernate commented May 28, 2023 • edited Loading

whitequark commented Jun 27, 2023

richardeoin commented Jan 27, 2024

slagernate commented Jan 30, 2024

whitequark commented Jan 30, 2024

slagernate commented Jan 30, 2024

slagernate commented Mar 12, 2024

whitequark Apr 9, 2024

Choose a reason for hiding this comment

slagernate Apr 11, 2024

Choose a reason for hiding this comment

whitequark Apr 11, 2024

Choose a reason for hiding this comment

slagernate Apr 11, 2024 • edited Loading

Choose a reason for hiding this comment

whitequark Apr 11, 2024

Choose a reason for hiding this comment

gatecat Apr 11, 2024

Choose a reason for hiding this comment

whitequark Apr 11, 2024

Choose a reason for hiding this comment

wanda-phi Apr 11, 2024

Choose a reason for hiding this comment

whitequark commented Apr 19, 2024

codecov bot commented Mar 2, 2023 •

edited

Loading

slagernate commented May 28, 2023 •

edited

Loading

slagernate Apr 11, 2024 •

edited

Loading