Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix comments and function arguments #116

Merged
merged 8 commits into from
Jan 8, 2025
Merged

Conversation

Giulero
Copy link
Collaborator

@Giulero Giulero commented Jan 8, 2025

@GiulioRomualdi spotted some wrong arguments in the pytorch interface.
Fixed joint_position to joint_postions as in the other functions.
Took the occasion also to fix other wrong comments.

Changing also the raise DeprecationWarning for the use of the root_link introduced in #114 to a more mild warning.warn().


📚 Documentation preview 📚: https://adam-docs--116.org.readthedocs.build/en/116/

@Giulero Giulero requested a review from GiulioRomualdi January 8, 2025 11:50
@Giulero
Copy link
Collaborator Author

Giulero commented Jan 8, 2025

Thanks @GiulioRomualdi ! Merging

@Giulero Giulero merged commit a6a60bd into main Jan 8, 2025
18 checks passed
@Giulero Giulero deleted the fix-comment-annotations branch January 8, 2025 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants