Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement post editing functionality #124

Closed
andregasser opened this issue Jan 30, 2023 · 1 comment · Fixed by #159
Closed

Implement post editing functionality #124

andregasser opened this issue Jan 30, 2023 · 1 comment · Fixed by #159
Assignees
@bocops
Labels
enhancement New feature or request good first issue Good for newcomers, low-hanging fruit
Milestone
2.0.0

Comments

@andregasser
Copy link
Owner

Editing a post is considered important basic functionality. Let's add it to the library before the 2.0.0 release.

Link to the API call:
https://docs.joinmastodon.org/methods/statuses/#edit
@andregasser andregasser added enhancement New feature or request good first issue Good for newcomers, low-hanging fruit labels Jan 30, 2023
@andregasser andregasser added this to the 2.0.0 milestone Jan 30, 2023
@andregasser andregasser changed the title Add post editing Implement post editing functionality Jan 30, 2023
@bocops
Copy link
Collaborator

bocops commented Jan 30, 2023

This should probably be done in combination with #108 and potentially also implement the return value for deleting a status, to be used in a delete&redraft action, which is somewhat similar to an edit action.

@bocops bocops mentioned this issue Jan 30, 2023
Open
bocops added a commit to bocops/bigbone that referenced this issue Jan 31, 2023
@bocops
add some missing members to Status entity
302752e 
- adds: card, text, edited_at, muted, bookmarked - text is necessary for work on editing statuses (andregasser#124)

- does not add: poll, filtered - held up by andregasser#129 and andregasser#130, respectively

- renames Card to PreviewCard, according to Mastodon API
@bocops bocops mentioned this issue Jan 31, 2023
Merged
bocops added a commit to bocops/bigbone that referenced this issue Jan 31, 2023
@bocops
add some missing members to Status entity
8d5189a 
- adds: card, text, edited_at, muted, bookmarked - text is necessary for work on editing statuses (andregasser#124)

- does not add: poll, filtered - held up by andregasser#129 and andregasser#130, respectively

- renames Card to PreviewCard, according to Mastodon API
andregasser pushed a commit that referenced this issue Jan 31, 2023
@bocops
add some missing members to Status entity (#131)
54da208 
* add some missing members to Status entity

- adds: card, text, edited_at, muted, bookmarked - text is necessary for work on editing statuses (#124)

- does not add: poll, filtered - held up by #129 and #130, respectively

- renames Card to PreviewCard, according to Mastodon API

* add some missing members to Status entity

- adds: card, text, edited_at, muted, bookmarked - text is necessary for work on editing statuses (#124)

- does not add: poll, filtered - held up by #129 and #130, respectively

- renames Card to PreviewCard, according to Mastodon API
bocops added a commit to bocops/bigbone that referenced this issue Feb 16, 2023
@bocops
Add missing Status methods, except for Status editing
57e8c09 
- adds: translating, bookmarking, muting, pinning
- postStatus now has language parameter
- deleteStatus now returns a Status for subsequent editing
- reblogStatus now has visibility parameter
- implements posting of poll statuses
- implements status scheduling
- removes getCard (removed in Mastodon 3.0.0 after deprecation in 2.6.0)
- adds entities Poll, ScheduledStatus, Translation
- makes all new methods available via Rx
- includes tests and test assets for all new methods
- does not implement status editing (see andregasser#124)

Closes andregasser#125, andregasser#129, andregasser#16
@bocops bocops mentioned this issue Feb 16, 2023
Merged
andregasser added a commit that referenced this issue Feb 28, 2023
@bocops @andregasser
Add missing Status methods, except for Status editing (#149)
ef46ba5 
* Add missing Status methods, except for Status editing

- adds: translating, bookmarking, muting, pinning
- postStatus now has language parameter
- deleteStatus now returns a Status for subsequent editing
- reblogStatus now has visibility parameter
- implements posting of poll statuses
- implements status scheduling
- removes getCard (removed in Mastodon 3.0.0 after deprecation in 2.6.0)
- adds entities Poll, ScheduledStatus, Translation
- makes all new methods available via Rx
- includes tests and test assets for all new methods
- does not implement status editing (see #124)

Closes #125, #129, #16

* Adds missing JvmOverloads annotation and links to entity documentation

---------

Co-authored-by: André Gasser <[email protected]>
@bocops bocops mentioned this issue Mar 7, 2023
Merged
@bocops bocops self-assigned this Mar 8, 2023
@bocops bocops mentioned this issue Mar 8, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bocops bocops

Labels
enhancement New feature or request good first issue Good for newcomers, low-hanging fruit
Projects
None yet
Milestone
2.0.0
Development

Successfully merging a pull request may close this issue.

Implement post editing functionality bocops/bigbone
2 participants
@andregasser @bocops