Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print the transaction's chain ID in expert mode. (re-opened from #4332 after revert) #4341

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

tzemanovic
Copy link
Member

Describe your changes

An attempt to address #4282 by displaying the chain ID of the transaction in expert mode. The chain ID is still not printed in normal mode because too much information is already being displayed there. See attached what the test vectors would look like after this change: testvecs-formatted.json.gz for the JSON output and testdbgs.txt.gz for the debug formatting.

Checklist before merging

  • If this PR has some consensus breaking changes, I added the corresponding breaking:: labels
    • This will require 2 reviewers to approve the changes
  • If this PR requires changes to the docs or specs, a corresponding PR is opened in the namada-docs repo
    • Relevant PR if applies:
  • If this PR affects services such as namada-indexer or namada-masp-indexer, a corresponding PR is opened in that repo
    • Relevant PR if applies:

@tzemanovic tzemanovic changed the title Print the transaction's chain ID in expert mode. (re-opened after revert) Print the transaction's chain ID in expert mode. (re-opened from #4332 after revert) Feb 5, 2025
Copy link

codecov bot commented Feb 5, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 74.18%. Comparing base (73bf957) to head (3907056).
Report is 83 commits behind head on main.

Files with missing lines Patch % Lines
crates/sdk/src/signing.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4341      +/-   ##
==========================================
+ Coverage   74.15%   74.18%   +0.03%     
==========================================
  Files         345      345              
  Lines      110548   110633      +85     
==========================================
+ Hits        81975    82075     +100     
+ Misses      28573    28558      -15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants