Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print the transaction's chain ID in expert mode. (re-opened from #4332 after revert) #4341

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Print the transaction's chain ID in expert mode. (re-opened from #4332 after revert) #4341

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8b0fd55
Print the transaction's chain ID in expert mode.
murisi Feb 5, 2025
3907056
Added a changelog entry.
murisi Feb 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .changelog/unreleased/improvements/4282-test-vectors-with-chain-ids.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
- Make the test vector generator print the chain ID of transactions in expert
mode ([\#4282](https://github.com/anoma/namada/issues/4282))
1 change: 1 addition & 0 deletions crates/sdk/src/signing.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2182,6 +2182,7 @@ pub async fn to_ledger_vector(
.map_err(|e| Error::Other(format!("{}", e)))?,
);
tv.output_expert.extend(vec![
format!("Chain ID : {}", tx.header.chain_id),
format!(
"Timestamp : {}",
format_timestamp(tx.header.timestamp)
Expand Down
Loading